Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 61913005: Use the large pdb workaround on chrome_frame_reliability_tests. (Closed)

Created:
7 years, 1 month ago by Sébastien Marchand
Modified:
7 years, 1 month ago
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use the large pdb workaround on chrome_frame_reliability_tests. If we don't do this we can't compile this target in Debug with component='static_library'. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome_frame/chrome_frame.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Sébastien Marchand
PTAL.
7 years, 1 month ago (2013-11-07 05:11:25 UTC) #1
Sébastien Marchand
+robertshield as Erik's on vacations.
7 years, 1 month ago (2013-11-07 18:55:50 UTC) #2
Sébastien Marchand
+robertshield for real this time :)
7 years, 1 month ago (2013-11-07 18:57:01 UTC) #3
robertshield
lgtm
7 years, 1 month ago (2013-11-07 20:55:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/61913005/1
7 years, 1 month ago (2013-11-07 20:55:49 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-07 21:07:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/61913005/1
7 years, 1 month ago (2013-11-07 21:12:11 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-07 23:30:33 UTC) #8
Sébastien Marchand
It doesn't seem to be caused by my CL... Trying to land it one more ...
7 years, 1 month ago (2013-11-07 23:39:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/61913005/1
7 years, 1 month ago (2013-11-07 23:46:33 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-08 00:23:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/61913005/1
7 years, 1 month ago (2013-11-08 03:54:35 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 06:24:36 UTC) #13
Message was sent while issue was closed.
Change committed as 233803

Powered by Google App Engine
This is Rietveld 408576698