DescriptionRevert of Credential Manager: Return the first valid item from the PasswordStore. (patchset #1 id:1 of https://codereview.chromium.org/613143003/)
Reason for revert:
Tests CredentialManagerOnRequestCredentialWhileRequestPending,
CredentialManagerOnRequestCredentialWithFullPasswordStore
failing on Linux ASan LSan Tests (1)
link: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6228
errors like:
Direct leak of 1056 byte(s) in 1 object(s) allocated from:
#0 0x52e7cb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/components_unittests+0x52e7cb)
#1 0x21e965f in password_manager::TestPasswordStore::GetLoginsImpl(autofill::PasswordForm const&, password_manager::PasswordStore::AuthorizationPromptPolicy, base::Callback\u003Cvoid (std::__1::vector\u003Cautofill::PasswordForm*, std::__1::allocator\u003Cautofill::PasswordForm*> > const&)> const&) components/password_manager/core/browser/test_password_store.cc:103:5
Original issue's description:
> Credential Manager: Return the first valid item from the PasswordStore.
>
> This patch completes the initial, dead simple, pretty dumb implementation
> of '.request()'. We poke at the PasswordStore for the origin currently
> committed in the RenderViewHost's main frame, and if we get anything at
> all, we return it.
>
> We can't expose this implementation to the web for obvious reasons. But
> it's pefectly wonderful for testing.
>
> BUG=400674
>
> Committed: https://crrev.com/e4c5d27cdb953539094774f7b6c57637a2bba4e1
> Cr-Commit-Position: refs/heads/master@{#297598}
TBR=vabr@chromium.org,mkwst@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400674
Committed: https://crrev.com/dbd11635d503ba6bfe229cdeab96942bd0aea5d7
Cr-Commit-Position: refs/heads/master@{#297603}
Patch Set 1 #
Created: 6 years, 2 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|