Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 619033002: Revert of Credential Manager: Return the first valid item from the PasswordStore. (Closed)

Created:
6 years, 2 months ago by tapted
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@yay
Project:
chromium
Visibility:
Public.

Description

Revert of Credential Manager: Return the first valid item from the PasswordStore. (patchset #1 id:1 of https://codereview.chromium.org/613143003/) Reason for revert: Tests CredentialManagerOnRequestCredentialWhileRequestPending, CredentialManagerOnRequestCredentialWithFullPasswordStore failing on Linux ASan LSan Tests (1) link: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6228 errors like: Direct leak of 1056 byte(s) in 1 object(s) allocated from: #0 0x52e7cb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/components_unittests+0x52e7cb) #1 0x21e965f in password_manager::TestPasswordStore::GetLoginsImpl(autofill::PasswordForm const&, password_manager::PasswordStore::AuthorizationPromptPolicy, base::Callback\u003Cvoid (std::__1::vector\u003Cautofill::PasswordForm*, std::__1::allocator\u003Cautofill::PasswordForm*> > const&)> const&) components/password_manager/core/browser/test_password_store.cc:103:5 Original issue's description: > Credential Manager: Return the first valid item from the PasswordStore. > > This patch completes the initial, dead simple, pretty dumb implementation > of '.request()'. We poke at the PasswordStore for the origin currently > committed in the RenderViewHost's main frame, and if we get anything at > all, we return it. > > We can't expose this implementation to the web for obvious reasons. But > it's pefectly wonderful for testing. > > BUG=400674 > > Committed: https://crrev.com/e4c5d27cdb953539094774f7b6c57637a2bba4e1 > Cr-Commit-Position: refs/heads/master@{#297598} TBR=vabr@chromium.org,mkwst@chromium.org NOTREECHECKS=true NOTRY=true BUG=400674 Committed: https://crrev.com/dbd11635d503ba6bfe229cdeab96942bd0aea5d7 Cr-Commit-Position: refs/heads/master@{#297603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -67 lines) Patch
M components/password_manager/content/browser/content_credential_manager_dispatcher.cc View 3 chunks +9 lines, -18 lines 0 comments Download
M components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc View 5 chunks +2 lines, -31 lines 0 comments Download
M components/password_manager/content/common/credential_manager_types.h View 2 chunks +0 lines, -5 lines 0 comments Download
M components/password_manager/content/common/credential_manager_types.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tapted
Created Revert of Credential Manager: Return the first valid item from the PasswordStore.
6 years, 2 months ago (2014-10-01 07:00:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619033002/1
6 years, 2 months ago (2014-10-01 07:01:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as c6ceea6bc0a2ea0e8ae92cf51fc7bffa5ffeeeaf
6 years, 2 months ago (2014-10-01 07:01:56 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dbd11635d503ba6bfe229cdeab96942bd0aea5d7 Cr-Commit-Position: refs/heads/master@{#297603}
6 years, 2 months ago (2014-10-01 07:02:29 UTC) #4
Mike West
6 years, 2 months ago (2014-10-01 07:14:14 UTC) #5
Message was sent while issue was closed.
LGTM, thanks for reverting.

Powered by Google App Engine
This is Rietveld 408576698