Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chromeos/network/onc/onc_validator_unittest.cc

Issue 61903002: ChromeOS: Add more host verification options for OpenVpn. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_validator_unittest.cc
diff --git a/chromeos/network/onc/onc_validator_unittest.cc b/chromeos/network/onc/onc_validator_unittest.cc
index 4500d11031fd2b45c146e6d72c63a3aded0a3655..2fd91d09e3072ed5c5da11f2f58876b6d3e8f0cd 100644
--- a/chromeos/network/onc/onc_validator_unittest.cc
+++ b/chromeos/network/onc/onc_validator_unittest.cc
@@ -165,6 +165,9 @@ INSTANTIATE_TEST_CASE_P(
true),
OncParams("translation_of_shill_wifi_with_state.onc",
&kNetworkWithStateSignature,
+ false),
+ OncParams("valid_openvpn_with_cert_pems.onc",
+ &kNetworkConfigurationSignature,
false)));
namespace {
@@ -292,6 +295,9 @@ INSTANTIATE_TEST_CASE_P(
false),
RepairParams("",
"network-nested-state-field-repaired")),
+ std::make_pair(OncParams("openvpn-missing-verify-x509-name",
+ &kNetworkConfigurationSignature, false),
+ RepairParams("", "openvpn-missing-verify-x509-name")),
std::make_pair(OncParams("toplevel-with-repairable-networks",
&kToplevelConfigurationSignature,
false,
@@ -366,7 +372,11 @@ INSTANTIATE_TEST_CASE_P(
std::make_pair(OncParams("network-with-client-cert-pattern",
&kNetworkConfigurationSignature, true,
::onc::ONC_SOURCE_DEVICE_POLICY),
- RepairParams("", ""))));
+ RepairParams("", "")),
+ std::make_pair(OncParams("openvpn-invalid-verify-x509-type",
+ &kNetworkConfigurationSignature, false),
+ RepairParams("", ""))
+ ));
} // namespace onc
} // namespace chromeos
« no previous file with comments | « chromeos/network/onc/onc_validator.cc ('k') | chromeos/test/data/network/invalid_settings_with_repairs.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698