chromeos/test/data/network/valid_openvpn_with_cert_pems.onc - Issue 61903002: ChromeOS: Add more host verification options for OpenVpn.

Side by Side Diff: chromeos/test/data/network/valid_openvpn_with_cert_pems.onc

Issue 61903002: ChromeOS: Add more host verification options for OpenVpn. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chromeos/network/onc/onc_validator.cc ('K') | « chromeos/test/data/network/translation_of_shill_openvpn.onc ('k') | components/onc/docs/onc_spec.html » ('j') | components/onc/docs/onc_spec.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "GUID": "{a3860e83-f03d-4cb1-bafa-b22c9e746950}",	2 "GUID": "{a3860e83-f03d-4cb1-bafa-b22c9e746950}",

3 "Name": "my vpn",	3 "Name": "my vpn",

4 "Type": "VPN",	4 "Type": "VPN",

5 "VPN": {	5 "VPN": {

6 "AutoConnect": true,	6 "AutoConnect": true,

7 "Host": "vpn.my.domain.com",	7 "Host": "vpn.my.domain.com",

8 "Type": "OpenVPN",	8 "Type": "OpenVPN",

9 "OpenVPN": {	9 "OpenVPN": {

10 "AuthRetry": "interact",	10 "AuthRetry": "interact",

11 "CompLZO": "true",	11 "CompLZO": "true",

12 "KeyDirection": "1",	12 "KeyDirection": "1",

13 "Password": "some password",	13 "Password": "some password",

14 "Port": 443,	14 "Port": 443,

15 "Proto": "udp",	15 "Proto": "udp",

16 "PushPeerInfo": true,	16 "PushPeerInfo": true,

17 "RemoteCertEKU": "TLS Web Server Authentication",	17 "RemoteCertEKU": "TLS Web Server Authentication",

18 "RemoteCertKU": [	18 "RemoteCertKU": [

19 "e0"	19 "e0"

20 ],	20 ],

21 "RemoteCertTLS": "server",	21 "RemoteCertTLS": "server",

22 "RenegSec": 0,	22 "RenegSec": 0,

23 "SaveCredentials": false,	23 "SaveCredentials": false,

24 "ServerCAPEMs": [ "pem1", "pem2" ],	24 "ServerCAPEMs": [ "pem1", "pem2" ],

25 "ServerPollTimeout": 10,	25 "ServerPollTimeout": 10,

26 "StaticChallenge": "Please enter token OTP",	26 "StaticChallenge": "Please enter token OTP",

27 "TLSAuthContents": "-----BEGIN OpenVPN Static key V1-----\n83f8e7ccd 99be189b4663e18615f9166\nd885cdea6c8accb0ebf5be304f0b8081\n5404f2a6574e029815d7a 2fb65b83d0c\n676850714c6a56b23415a78e06aad6b1\n34900dd512049598382039e4816cb5ff\ n1848532b71af47578c9b4a14b5bca49f\n99e0ae4dae2f4e5eadfea374aeb8fb1e\na6fdf02adc7 3ea778dfd43d64bf7bc75\n7779d629498f8c2fbfd32812bfdf6df7\n8cebafafef3e5496cb13202 274f2768a\n1959bc53d67a70945c4c8c6f34b63327\nfb60dc84990ffec1243461e0b6310f61\ne 90aee1f11fb6292d6f5fcd7cd508aab\n50d80f9963589c148cb4b933ec86128d\ned77d3fad6005 b62f36369e2319f52bd\n09c6d2e52cce2362a05009dc29b6b39a\n-----END OpenVPN Static k ey V1-----\n",	27 "TLSAuthContents": "-----BEGIN OpenVPN Static key V1-----\n83f8e7ccd 99be189b4663e18615f9166\nd885cdea6c8accb0ebf5be304f0b8081\n5404f2a6574e029815d7a 2fb65b83d0c\n676850714c6a56b23415a78e06aad6b1\n34900dd512049598382039e4816cb5ff\ n1848532b71af47578c9b4a14b5bca49f\n99e0ae4dae2f4e5eadfea374aeb8fb1e\na6fdf02adc7 3ea778dfd43d64bf7bc75\n7779d629498f8c2fbfd32812bfdf6df7\n8cebafafef3e5496cb13202 274f2768a\n1959bc53d67a70945c4c8c6f34b63327\nfb60dc84990ffec1243461e0b6310f61\ne 90aee1f11fb6292d6f5fcd7cd508aab\n50d80f9963589c148cb4b933ec86128d\ned77d3fad6005 b62f36369e2319f52bd\n09c6d2e52cce2362a05009dc29b6b39a\n-----END OpenVPN Static k ey V1-----\n",

28 "TLSRemote": "my.domain.com",	28 "TLSRemote": "my.domain.com",

29 "Username": "abc ${LOGIN_EMAIL} def",	29 "Username": "abc ${LOGIN_EMAIL} def",

	30 "VerifyHash": "some hash",

	31 "VerifyX509": {

	32 "Name": "some x509 name",

	33 "Type": "some x509 type"
	bartfab (slow) 2013/11/07 10:48:56 My understanding of ONC is very limited but I wond My understanding of ONC is very limited but I wonder how this is valid. "Name" is free-form but "Type" can only be one of a handful supported values. How is "some x509 type" valid? pneubeck (no reviews) 2013/11/11 11:53:43 you're right. this file was used by the translator Show quoted text On 2013/11/07 10:48:56, bartfab wrote: > My understanding of ONC is very limited but I wonder how this is valid. "Name" > is free-form but "Type" can only be one of a handful supported values. How is > "some x509 type" valid? you're right. this file was used by the translator only and not validated. I added this to the validation unittest. Done.
	34 }

30 }	35 }

31 }	36 }

32 }	37 }

OLD	NEW