Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 619003003: Revert of No longer requiring pixel output for WebRTC tests. (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of No longer requiring pixel output for WebRTC tests. (patchset #4 id:60001 of https://codereview.chromium.org/611953004/) Reason for revert: Turns out this change makes video+canvas grabbing produce junk; this is not good since our tests depend on that working. Reverting. Original issue's description: > No longer requiring pixel output for WebRTC tests. > > We used to require pixel output for our canvas-scraping, but that > appears to no longer be required. This speeds up the test 3x on my > win machine, from 30 seconds to about 10. > > The content_browsertests on ChromeOS will still enable pixel > output since it seems the requirements there are different - video > tags will not work unless that is enabled, it seems. I think > that's fine since our original problem was with the browser_tests > anyway, and I think the content_browsertests are probably fast > enough on ChromeOS anyway (whereas the browser_tests weren't). > > BUG=396505 > > Committed: https://crrev.com/e6a342dcab57c3a2de1fd21301f37fdf3f8ad070 > Cr-Commit-Position: refs/heads/master@{#297654} TBR=tommi@chromium.org,xians@google.com NOTREECHECKS=true NOTRY=true BUG=396505 Committed: https://crrev.com/b8c01fc3dc165b8d3d6aea166776f07b25f06b04 Cr-Commit-Position: refs/heads/master@{#297800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/browser/media/chrome_webrtc_browsertest.cc View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/webrtc_content_browsertest_base.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund_chromium
Created Revert of No longer requiring pixel output for WebRTC tests.
6 years, 2 months ago (2014-10-02 10:57:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619003003/1
6 years, 2 months ago (2014-10-02 10:58:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as bd59c3f3271e46ffd6f76893da2bd2803297204d
6 years, 2 months ago (2014-10-02 10:59:58 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 11:00:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8c01fc3dc165b8d3d6aea166776f07b25f06b04
Cr-Commit-Position: refs/heads/master@{#297800}

Powered by Google App Engine
This is Rietveld 408576698