Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 61893020: Set TargetMachine for libs too (Closed)

Created:
7 years, 1 month ago by scottmg
Modified:
7 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Set TargetMachine for libs too In VS2013, remoting_host_event_logger.lib fails with: FAILED: E:\b\depot_tools\python_bin\python.exe gyp-win-tool link-wrapper environment.x86 lib.exe /nologo /ignore:4221 /OUT:obj\remoting\remoting_host_event_logger.lib @obj\remoting\remoting_host_event_logger.lib.rsp LINK : warning LNK4068: /MACHINE not specified; defaulting to X64 obj\remoting\host\remoting_host_event_logger.host_event_logger_win.obj : fatalerror LNK1112: module machine type 'X86' conflicts with target machine type 'x64' This is because if unspecified, lib.exe chooses the target architecture based on the first input file. In this lib, the first file (there's only 2) happens to be a .res compiled from a .rc, which doesn't have an architecture. Because we use the amd64 toolchain, lib decides to guess that it should use x64. This fails to lib because the other .cc input is x86. After adding support for setting the architecture for libs in gyp here https://codereview.chromium.org/68133006/ this sets it explicitly on our libs too. R=cpu@chromium.org BUG=309197 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/common.gypi View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
7 years, 1 month ago (2013-11-12 06:20:07 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
7 years, 1 month ago (2013-11-12 20:14:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/61893020/1
7 years, 1 month ago (2013-11-12 20:23:12 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 22:44:42 UTC) #4
Message was sent while issue was closed.
Change committed as 234656

Powered by Google App Engine
This is Rietveld 408576698