Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 61893003: MIPS: Improve implementation of HSeqStringSetChar. (Closed)

Created:
7 years, 1 month ago by kilvadyb
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Improve implementation of HSeqStringSetChar. Port r17521 (c51c75e) Original commit message: This improves the generated code for HSeqStringSetChar across all platforms, taking advantage of constant operands whenever possible. It also drops the unused DefineSameAsFirst constraint for the register allocator on x64 and ia32, where it caused unnecessary spills when the string operand was live across the HSeqStringSetChar instruction. A new GVN flag StringChars is introduced to express dependencies between HSeqStringSetChar, HStringCharCodeAt and the upcoming HSeqStringGetChar (the GVNFlags type is now 64bit in size). Also improves the test case. TEST=mjsunit/string-natives BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -29 lines) Patch
M src/mips/lithium-codegen-mips.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +31 lines, -21 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Lind
LGTM, I'll commit it.
7 years, 1 month ago (2013-11-06 23:50:37 UTC) #1
Paul Lind
7 years, 1 month ago (2013-11-06 23:53:46 UTC) #2
Committed as r17536.

Powered by Google App Engine
This is Rietveld 408576698