Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 618863002: Chromecast: device identification for whitelisted apps and servers. (Closed)

Created:
6 years, 2 months ago by gunsch
Modified:
6 years, 2 months ago
Reviewers:
lcwu1, dougsteed
CC:
chromium-reviews, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: device identification for whitelisted apps and servers. R=dougsteed@chromium.org,lcwu@chromium.org BUG=336640 Committed: https://crrev.com/b098afcdc9323e47baa8ad1f268f945a0b7120c3 Cr-Commit-Position: refs/heads/master@{#297898}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M chromecast/shell/browser/cast_content_browser_client.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chromecast/shell/browser/cast_content_browser_client.cc View 1 3 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
gunsch
6 years, 2 months ago (2014-09-30 18:13:30 UTC) #1
gunsch
ping?
6 years, 2 months ago (2014-10-02 16:17:26 UTC) #2
dougsteed
lgtm
6 years, 2 months ago (2014-10-02 17:27:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618863002/1
6 years, 2 months ago (2014-10-02 19:09:17 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-02 19:09:20 UTC) #7
lcwu1
LGTM % a nit in comment. https://codereview.chromium.org/618863002/diff/1/chromecast/shell/browser/cast_content_browser_client.cc File chromecast/shell/browser/cast_content_browser_client.cc (right): https://codereview.chromium.org/618863002/diff/1/chromecast/shell/browser/cast_content_browser_client.cc#newcode158 chromecast/shell/browser/cast_content_browser_client.cc:158: // it, because ...
6 years, 2 months ago (2014-10-02 19:56:34 UTC) #8
gunsch
https://codereview.chromium.org/618863002/diff/1/chromecast/shell/browser/cast_content_browser_client.cc File chromecast/shell/browser/cast_content_browser_client.cc (right): https://codereview.chromium.org/618863002/diff/1/chromecast/shell/browser/cast_content_browser_client.cc#newcode158 chromecast/shell/browser/cast_content_browser_client.cc:158: // it, because CastNetworkDelegate is bound to the latter ...
6 years, 2 months ago (2014-10-02 20:29:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618863002/20001
6 years, 2 months ago (2014-10-02 20:30:59 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4bc25ae983d4808edcfcb06d5369db28a3ab253e
6 years, 2 months ago (2014-10-02 20:54:26 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 20:54:51 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b098afcdc9323e47baa8ad1f268f945a0b7120c3
Cr-Commit-Position: refs/heads/master@{#297898}

Powered by Google App Engine
This is Rietveld 408576698