Compositor thread plumbing for layout rectangle debug info.

cc/layers/layer.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/layer.h"
 
 #include <algorithm>
 
 #include "base/debug/trace_event.h"
 #include "base/location.h"
@@ skipping 911 matching lines @@
 
   layer_animation_controller_->PushAnimationUpdatesTo(
       layer->layer_animation_controller());
 
   // Reset any state that should be cleared for the next update.
   stacking_order_changed_ = false;
   update_rect_ = gfx::RectF();
 
   needs_push_properties_ = false;
   num_dependents_need_push_properties_ = 0;
+
+  layer->SetDebugInfo(debug_info_);

[enne (OOO), 2013/11/25 20:16:45]

ConvertableToTraceFormat is not thread-safe refcounted.  This seems a little
dodgy.

[chrishtr_gmail.com, 2013/11/25 22:48:25]

Good catch. I'll try the approach we discussed offline of adding ::AsValue to
the debug info object.

[chrishtr_gmail.com, 2013/11/26 21:49:04]

Updated to not store the debug_Info_ object at all here.

 }
 
 scoped_ptr<LayerImpl> Layer::CreateLayerImpl(LayerTreeImpl* tree_impl) {
   return LayerImpl::Create(tree_impl, layer_id_);
 }
 
 bool Layer::DrawsContent() const {
   return is_drawable_;
 }
 
 void Layer::SavePaintProperties() {
   DCHECK(layer_tree_host_);
 
   // TODO(reveman): Save all layer properties that we depend on not
   // changing until PushProperties() has been called. crbug.com/231016
   paint_properties_.bounds = bounds_;
   paint_properties_.source_frame_number =
       layer_tree_host_->source_frame_number();
 }
 
 bool Layer::Update(ResourceUpdateQueue* queue,
                    const OcclusionTracker* occlusion) {
   DCHECK(layer_tree_host_);
   DCHECK_EQ(layer_tree_host_->source_frame_number(),
             paint_properties_.source_frame_number) <<
       "SavePaintProperties must be called for any layer that is painted.";
   return false;
 }
 
+void Layer::SetDebugInfo(base::debug::ConvertableToTraceFormat* debug_info) {
+  debug_info_ = debug_info;
+}
+
 bool Layer::NeedMoreUpdates() {
   return false;
 }
 
 std::string Layer::DebugName() {
   return client_ ? client_->DebugName() : std::string();
 }
 
 void Layer::SetCompositingReasons(CompositingReasons reasons) {
   compositing_reasons_ = reasons;
@@ skipping 119 matching lines @@
     clip_parent_->RemoveClipChild(this);
 
   clip_parent_ = NULL;
 }
 
 void Layer::RunMicroBenchmark(MicroBenchmark* benchmark) {
   benchmark->RunOnLayer(this);
 }
 
 }  // namespace cc