Improved performance of fetching variation parameters in AutomaticProfileResetter.

Improved performance of fetching variation parameters in AutomaticProfileResetter.

This is a follow-up to https://codereview.chromium.org/50883003/.

BUG=298036
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233556

[engedy, 2013-11-06 16:54:01]

Please take a look.

[Alexei Svitkine (slow), 2013-11-06 17:30:28]

LGTM with a nit, thanks!

https://codereview.chromium.org/61883005/diff/1/chrome/browser/profile_resett...
File chrome/browser/profile_resetter/automatic_profile_resetter.cc (right):

https://codereview.chromium.org/61883005/diff/1/chrome/browser/profile_resett...
chrome/browser/profile_resetter/automatic_profile_resetter.cc:137: //
|ħash_seed| to use instead of the baked-in ones, retrieves those and returns
Nit: Is the 'h' in hash_seed some accented one here (ħ), instead of the regular
one (h)?

[engedy, 2013-11-06 18:14:27]

Dominic, can you please review for OWNER's approval?

https://codereview.chromium.org/61883005/diff/1/chrome/browser/profile_resett...
File chrome/browser/profile_resetter/automatic_profile_resetter.cc (right):

https://codereview.chromium.org/61883005/diff/1/chrome/browser/profile_resett...
chrome/browser/profile_resetter/automatic_profile_resetter.cc:137: //
|ħash_seed| to use instead of the baked-in ones, retrieves those and returns
On 2013/11/06 17:30:29, Alexei Svitkine wrote:
> Nit: Is the 'h' in hash_seed some accented one here (ħ), instead of the
regular
> one (h)?

Wow, I have no idea how that happened. Thanks for spotting it.

[battre, 2013-11-06 18:25:27]

lgtm

[commit-bot: I haz the power, 2013-11-06 19:02:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/engedy@chromium.org/61883005/60001

[commit-bot: I haz the power, 2013-11-06 20:20:41]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[engedy, 2013-11-06 20:35:57]

Dominic, please take another look.

[engedy, 2013-11-06 20:43:39]

On 2013/11/06 20:35:57, engedy wrote:
> Dominic, please take another look.

As discussed off-line, this is not the nicest way, but the surest.

[commit-bot: I haz the power, 2013-11-06 21:01:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/engedy@chromium.org/61883005/370001

[commit-bot: I haz the power, 2013-11-07 08:49:55]

Change committed as 233556