Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2368)

Unified Diff: extensions/renderer/resources/web_view_events.js

Issue 618823002: GuestView: Move lifetime management out of content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed browser_pluign_browsertest + fixed lifetime issue (brittle) Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/web_view_events.js
diff --git a/extensions/renderer/resources/web_view_events.js b/extensions/renderer/resources/web_view_events.js
index 13af04c544f941750f79072dc6a8aae9e00f29d6..69e37110c8ab5593a5283f78fe205e7f4bf0c287 100644
--- a/extensions/renderer/resources/web_view_events.js
+++ b/extensions/renderer/resources/web_view_events.js
@@ -158,7 +158,6 @@ function WebViewEvents(webViewInternal, viewInstanceId) {
// Sets up events.
WebViewEvents.prototype.setup = function() {
this.setupFrameNameChangedEvent();
- this.setupPluginDestroyedEvent();
this.webViewInternal.maybeSetupChromeWebViewEvents();
this.webViewInternal.setupExperimentalContextMenus();
@@ -174,12 +173,6 @@ WebViewEvents.prototype.setupFrameNameChangedEvent = function() {
}.bind(this), {instanceId: this.viewInstanceId});
};
-WebViewEvents.prototype.setupPluginDestroyedEvent = function() {
- PluginDestroyedEvent.addListener(function(e) {
- this.webViewInternal.onPluginDestroyed();
- }.bind(this), {instanceId: this.viewInstanceId});
-};
-
WebViewEvents.prototype.getEvents = function() {
var experimentalEvents = this.webViewInternal.maybeGetExperimentalEvents();
for (var eventName in experimentalEvents) {

Powered by Google App Engine
This is Rietveld 408576698