extensions/browser/guest_view/web_view/web_view_constants.cc - Issue 618823002: GuestView: Move lifetime management out of content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_constants.cc

Issue 618823002: GuestView: Move lifetime management out of content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed browser_pluign_browsertest + fixed lifetime issue (brittle) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/web_view_constants.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_constants.cc b/extensions/browser/guest_view/web_view/web_view_constants.cc

index 9454292e106a571aec9846974222677d32b81a60..9526d43c4d209d9a2dd60bf891e191d811ec359d 100644

--- a/extensions/browser/guest_view/web_view/web_view_constants.cc

+++ b/extensions/browser/guest_view/web_view/web_view_constants.cc

@@ -42,7 +42,6 @@ const char kEventLoadStop[] = "webViewInternal.onLoadStop";

const char kEventMessage[] = "webViewInternal.onMessage";

const char kEventNewWindow[] = "webViewInternal.onNewWindow";

const char kEventPermissionRequest[] = "webViewInternal.onPermissionRequest";

-const char kEventPluginDestroyed[] = "webViewInternal.onPluginDestroyed";

const char kEventResponsive[] = "webViewInternal.onResponsive";

const char kEventSizeChanged[] = "webViewInternal.onSizeChanged";

const char kEventUnresponsive[] = "webViewInternal.onUnresponsive";