content/common/browser_plugin/browser_plugin_messages.h - Issue 618823002: GuestView: Move lifetime management out of content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/browser_plugin/browser_plugin_messages.h

Issue 618823002: GuestView: Move lifetime management out of content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed browser_pluign_browsertest + fixed lifetime issue (brittle) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/browser_plugin/browser_plugin_messages.h

diff --git a/content/common/browser_plugin/browser_plugin_messages.h b/content/common/browser_plugin/browser_plugin_messages.h

index 80c8e23d88b08228dae518ae8c67409ff654e2db..aaeae277edfebc9681fd9b987c3e4dabf6cccdfa 100644

--- a/content/common/browser_plugin/browser_plugin_messages.h

+++ b/content/common/browser_plugin/browser_plugin_messages.h

@@ -125,11 +125,6 @@ IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_ReclaimCompositorResources,

int /* browser_plugin_instance_id */,

FrameHostMsg_ReclaimCompositorResources_Params /* params */)

-// When a BrowserPlugin has been removed from the embedder's DOM, it informs

-// the browser process to cleanup the guest.

-IPC_MESSAGE_ROUTED1(BrowserPluginHostMsg_PluginDestroyed,

- int /* browser_plugin_instance_id */)

// Tells the guest it has been shown or hidden.

IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_SetVisibility,

int /* browser_plugin_instance_id */,