content/browser/web_contents/web_contents_view_guest.h - Issue 618823002: GuestView: Move lifetime management out of content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_guest.h

Issue 618823002: GuestView: Move lifetime management out of content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed browser_pluign_browsertest + fixed lifetime issue (brittle) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_view_guest.h

diff --git a/content/browser/web_contents/web_contents_view_guest.h b/content/browser/web_contents/web_contents_view_guest.h

index 9a54375de4326f44aff5c946e0a0fc17538372e6..c8b662a681503ef6cf59799eb46338ad211be2f8 100644

--- a/content/browser/web_contents/web_contents_view_guest.h

+++ b/content/browser/web_contents/web_contents_view_guest.h

@@ -35,7 +35,9 @@ class WebContentsViewGuest : public WebContentsView,

WebContents* web_contents();

- void OnGuestInitialized(WebContentsView* parent_view);

+ void OnGuestAttached(WebContentsView* parent_view);

+ void OnGuestDetached(WebContentsView* old_parent_view);

// Converts the guest specific coordinates in |params| to embedder specific

// ones.