Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: chrome/browser/apps/web_view_browsertest.cc

Issue 618823002: GuestView: Move lifetime management out of content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix extensionoptions cleanup Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/web_view_browsertest.cc
diff --git a/chrome/browser/apps/web_view_browsertest.cc b/chrome/browser/apps/web_view_browsertest.cc
index dde5e2c1c14e57bdecd0f34589bcf9dec985ec49..3b64ebef5242d288ecc2a7560598ba64bf88dbe8 100644
--- a/chrome/browser/apps/web_view_browsertest.cc
+++ b/chrome/browser/apps/web_view_browsertest.cc
@@ -798,33 +798,6 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, AutoSize) {
<< message_;
}
-// Tests that a <webview> that is set to "display: none" after load and then
-// setting "display: block" re-renders the plugin properly.
-//
-// Initially after loading the <webview> and the test sets <webview> to
-// "display: none".
-// This causes the browser plugin to be destroyed, we then set the
-// style.display of the <webview> to block again and check that loadstop
-// fires properly.
-IN_PROC_BROWSER_TEST_F(WebViewTest, DisplayNoneAndBack) {
- LoadAppWithGuest("web_view/display_none_and_back");
-
- scoped_refptr<content::MessageLoopRunner> loop_runner(
- new content::MessageLoopRunner);
- WebContentsHiddenObserver observer(GetGuestWebContents(),
- loop_runner->QuitClosure());
-
- // Handled in platform_apps/web_view/display_none_and_back/main.js
- SendMessageToEmbedder("hide-guest");
- GetGuestViewManager()->WaitForGuestDeleted();
- ExtensionTestMessageListener test_passed_listener("WebViewTest.PASSED",
- false);
-
- SendMessageToEmbedder("show-guest");
- GetGuestViewManager()->WaitForGuestCreated();
- EXPECT_TRUE(test_passed_listener.WaitUntilSatisfied());
-}
-
// http://crbug.com/326332
IN_PROC_BROWSER_TEST_F(WebViewTest, DISABLED_Shim_TestAutosizeAfterNavigation) {
TestHelper("testAutosizeAfterNavigation", "web_view/shim", NO_TEST_SERVER);

Powered by Google App Engine
This is Rietveld 408576698