Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 618823002: GuestView: Move lifetime management out of content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.h
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h
index ccf52edfc5b3f91ece191530996e49e338d5081d..f1e1e834715049e9b5b5d9e9f7d70059c33bc94f 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.h
+++ b/extensions/browser/guest_view/web_view/web_view_guest.h
@@ -58,7 +58,7 @@ class WebViewGuest : public GuestView<WebViewGuest>,
static const char Type[];
// Request navigating the guest to the provided |src| URL.
- void NavigateGuest(const std::string& src);
+ void NavigateGuest(const std::string& src, bool force_navigation);
// Shows the context menu for the guest.
// |items| acts as a filter. This restricts the current context's default
@@ -343,10 +343,13 @@ class WebViewGuest : public GuestView<WebViewGuest>,
// Stores whether the contents of the guest can be transparent.
bool guest_opaque_;
+ // Stores the src URL of the WebView.
+ GURL src_;
+
// Handles the JavaScript dialog requests.
JavaScriptDialogHelper javascript_dialog_helper_;
- // Handels permission requests.
+ // Handles permission requests.
scoped_ptr<WebViewPermissionHelper> web_view_permission_helper_;
scoped_ptr<WebViewGuestDelegate> web_view_guest_delegate_;
« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_constants.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698