Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 618823002: GuestView: Move lifetime management out of content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.h
diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h
index f255e1f73d9d41a03f94f3bd55f57d152e4072a6..7c3bd43715ee303f25b62b726d7e4a95e9b7dc4f 100644
--- a/extensions/browser/guest_view/guest_view_base.h
+++ b/extensions/browser/guest_view/guest_view_base.h
@@ -102,7 +102,7 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
virtual void GuestDestroyed() {}
// This method is invoked when the guest RenderView is ready, e.g. because we
- // recreated it after a crash.
+ // recreated it after a crash or after reattachment.
//
// This gives the derived class an opportunity to perform some initialization
// work.
@@ -224,7 +224,10 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
return opener_.get();
}
- // Sets some additional chrome/ initialization parameters.
+ // Destroy this guest.
+ void Destroy();
+
+ // Saves the attach state of the custom element hosting this GuestView.
void SetAttachParams(const base::DictionaryValue& params);
void SetOpener(GuestViewBase* opener);
@@ -235,7 +238,6 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
int exit_code) OVERRIDE;
// BrowserPluginGuestDelegate implementation.
- virtual void Destroy() OVERRIDE FINAL;
virtual void DidAttach(int guest_proxy_routing_id) OVERRIDE FINAL;
virtual void ElementSizeChanged(const gfx::Size& old_size,
const gfx::Size& new_size) OVERRIDE FINAL;

Powered by Google App Engine
This is Rietveld 408576698