extensions/browser/api/web_view/web_view_internal_api.cc - Issue 618823002: GuestView: Move lifetime management out of content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_view/web_view_internal_api.cc

Issue 618823002: GuestView: Move lifetime management out of content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/web_view/web_view_internal_api.cc

diff --git a/extensions/browser/api/web_view/web_view_internal_api.cc b/extensions/browser/api/web_view/web_view_internal_api.cc

index c6ed1ce79feac19142725755c0f7cf87516b0eda..62b349707198b349ef9909575d7c72b492247e0e 100644

--- a/extensions/browser/api/web_view/web_view_internal_api.cc

+++ b/extensions/browser/api/web_view/web_view_internal_api.cc

@@ -65,7 +65,7 @@ bool WebViewInternalNavigateFunction::RunAsyncSafe(WebViewGuest* guest) {

webview::Navigate::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

std::string src = params->src;

- guest->NavigateGuest(src);

+ guest->NavigateGuest(src, true /* force_navigation */);

return true;

}