Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/browser/guest_view/app_view/app_view_guest.cc

Issue 618823002: GuestView: Move lifetime management out of content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed appview tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/browser_plugin/browser_plugin_guest.h ('K') | « extensions/browser/extension_function_histogram_value.h ('k') | extensions/browser/guest_view/extension_options/extension_options_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/app_view/app_view_guest.cc
diff --git a/extensions/browser/guest_view/app_view/app_view_guest.cc b/extensions/browser/guest_view/app_view/app_view_guest.cc
index e608a4904ff206ea775acb74c6cdf8c17c57afd1..92608ace93ec33f3290d780c4e95e26305e1e30a 100644
--- a/extensions/browser/guest_view/app_view/app_view_guest.cc
+++ b/extensions/browser/guest_view/app_view/app_view_guest.cc
@@ -203,8 +203,12 @@ void AppViewGuest::DidAttachToEmbedder() {
// element. This means that the host element knows how to route input
// events to the guest, and the guest knows how to get frames to the
// embedder.
+ if (!url_.is_valid())
+ return;
+
web_contents()->GetController().LoadURL(
url_, content::Referrer(), ui::PAGE_TRANSITION_LINK, std::string());
+ url_ = GURL();
}
void AppViewGuest::DidInitialize() {
« content/browser/browser_plugin/browser_plugin_guest.h ('K') | « extensions/browser/extension_function_histogram_value.h ('k') | extensions/browser/guest_view/extension_options/extension_options_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698