GuestView: Move lifetime management out of content

extensions/browser/api/guest_view/guest_view_internal_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/guest_view/guest_view_internal_api.h"
 
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "extensions/browser/guest_view/guest_view_base.h"
 #include "extensions/browser/guest_view/guest_view_manager.h"
@@ skipping 47 matching lines @@
     content::WebContents* guest_web_contents) {
   int guest_instance_id = 0;
   if (guest_web_contents) {
     GuestViewBase* guest = GuestViewBase::FromWebContents(guest_web_contents);
     guest_instance_id = guest->guest_instance_id();
   }
   SetResult(new base::FundamentalValue(guest_instance_id));
   SendResponse(true);
 }
 
+GuestViewInternalDestroyGuestFunction::
+    GuestViewInternalDestroyGuestFunction() {
+}
+
+GuestViewInternalDestroyGuestFunction::
+    ~GuestViewInternalDestroyGuestFunction() {
+}
+
+bool GuestViewInternalDestroyGuestFunction::RunAsync() {
+  scoped_ptr<guest_view_internal::DestroyGuest::Params> params(
+      guest_view_internal::DestroyGuest::Params::Create(*args_));
+  EXTENSION_FUNCTION_VALIDATE(params.get());
+  GuestViewBase* guest = GuestViewBase::From(
+      render_view_host()->GetProcess()->GetID(), params->instance_id);
+  if (!guest)
+    return false;

[lfg, 2014/09/30 18:59:27]

Maybe should provide feedback to the javascript API that there was an error
destroying the guest.

[Fady Samuel, 2014/09/30 22:50:03]

This code is likely racy at tear down. The embedder process is getting rid of
its elements, and the browser process sees that the embedder is doing that and
tries to kill the guest as well. I'm hesitant to add an error.

[lfg, 2014/09/30 23:29:42]

Acknowledged.

+  guest->Destroy();
+  SendResponse(true);
+  return true;
+}
+
 GuestViewInternalSetAutoSizeFunction::
     GuestViewInternalSetAutoSizeFunction() {
 }
 
 GuestViewInternalSetAutoSizeFunction::
     ~GuestViewInternalSetAutoSizeFunction() {
 }
 
 bool GuestViewInternalSetAutoSizeFunction::RunAsync() {
   scoped_ptr<guest_view_internal::SetAutoSize::Params> params(
       guest_view_internal::SetAutoSize::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
   GuestViewBase* guest = GuestViewBase::From(
       render_view_host()->GetProcess()->GetID(), params->instance_id);
   if (!guest)
     return false;
   guest->SetAutoSize(params->params.enable_auto_size,
                      gfx::Size(params->params.min.width,
                                params->params.min.height),
                      gfx::Size(params->params.max.width,
                                params->params.max.height));
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions