extensions/browser/guest_view/extension_options/extension_options_guest.h - Issue 618823002: GuestView: Move lifetime management out of content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/guest_view/extension_options/extension_options_guest.h

Issue 618823002: GuestView: Move lifetime management out of content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « extensions/browser/guest_view/app_view/app_view_guest.cc ('k') | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_ H_	5 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_ H_

6 #define EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_ H_	6 #define EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_ H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "extensions/browser/extension_function_dispatcher.h"	9 #include "extensions/browser/extension_function_dispatcher.h"

10 #include "extensions/browser/guest_view/extension_options/extension_options_gues t_delegate.h"	10 #include "extensions/browser/guest_view/extension_options/extension_options_gues t_delegate.h"

(...skipping 59 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
70 int guest_instance_id);	70 int guest_instance_id);

71 virtual ~ExtensionOptionsGuest();	71 virtual ~ExtensionOptionsGuest();

72 void OnRequest(const ExtensionHostMsg_Request_Params& params);	72 void OnRequest(const ExtensionHostMsg_Request_Params& params);

73 void SetUpAutoSize();	73 void SetUpAutoSize();

74	74

75 scoped_ptr<extensions::ExtensionFunctionDispatcher>	75 scoped_ptr<extensions::ExtensionFunctionDispatcher>

76 extension_function_dispatcher_;	76 extension_function_dispatcher_;

77 scoped_ptr<extensions::ExtensionOptionsGuestDelegate>	77 scoped_ptr<extensions::ExtensionOptionsGuestDelegate>

78 extension_options_guest_delegate_;	78 extension_options_guest_delegate_;

79 GURL options_page_;	79 GURL options_page_;

	80 bool has_navigated_;

80	81

81 DISALLOW_COPY_AND_ASSIGN(ExtensionOptionsGuest);	82 DISALLOW_COPY_AND_ASSIGN(ExtensionOptionsGuest);

82 };	83 };

83	84

84 } // namespace extensions	85 } // namespace extensions

85	86

86 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUE ST_H_	87 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUE ST_H_

OLD	NEW