Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 618763004: Swarm Linux memory bots. (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -25 lines) Patch
M testing/buildbot/chromium.memory.json View 1 chunk +65 lines, -25 lines 4 comments Download

Messages

Total messages: 7 (1 generated)
jam
6 years, 2 months ago (2014-09-30 16:08:03 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/618763004/diff/1/testing/buildbot/chromium.memory.json File testing/buildbot/chromium.memory.json (right): https://codereview.chromium.org/618763004/diff/1/testing/buildbot/chromium.memory.json#newcode11 testing/buildbot/chromium.memory.json:11: "shards": 3 Only 3? https://codereview.chromium.org/618763004/diff/1/testing/buildbot/chromium.memory.json#newcode58 testing/buildbot/chromium.memory.json:58: } maybe ...
6 years, 2 months ago (2014-09-30 16:11:54 UTC) #3
jam
https://codereview.chromium.org/618763004/diff/1/testing/buildbot/chromium.memory.json File testing/buildbot/chromium.memory.json (right): https://codereview.chromium.org/618763004/diff/1/testing/buildbot/chromium.memory.json#newcode11 testing/buildbot/chromium.memory.json:11: "shards": 3 On 2014/09/30 16:11:54, M-A Ruel wrote: > ...
6 years, 2 months ago (2014-09-30 16:14:52 UTC) #4
M-A Ruel
great, lgtm
6 years, 2 months ago (2014-09-30 16:15:32 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/743b5fb449ece55c680649207a9b25790f488889 Cr-Commit-Position: refs/heads/master@{#297431}
6 years, 2 months ago (2014-09-30 16:17:50 UTC) #6
jam
6 years, 2 months ago (2014-09-30 16:18:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
743b5fb449ece55c680649207a9b25790f488889 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698