Unit test for sync online wallpaper

Unit test for sync online wallpaper

BUG=416130
Committed: https://crrev.com/9c99a1d7cd522e23f1232e53a181c9b21bda2216
Cr-Commit-Position: refs/heads/master@{#297542}

[bshe, 2014-09-30 17:16:51]

bshe@chromium.org changed reviewers:
+ kevers@chromium.org

[bshe, 2014-09-30 17:16:51]

Hi Kevin.

Do you mind to take a look at this CL? Thanks

[kevers, 2014-09-30 18:12:03]

lgtm with nit.

https://codereview.chromium.org/618743003/diff/20001/chrome/test/data/webui/m...
File chrome/test/data/webui/mock_controller.js (right):

https://codereview.chromium.org/618743003/diff/20001/chrome/test/data/webui/m...
chrome/test/data/webui/mock_controller.js:52: * @private
Based on direct access from test case, this is not private.  If the intention is
the make it private, then the variable should end in an underscore and be
modified via a  setter.

[bshe, 2014-09-30 21:59:48]

Thanks for review!

https://codereview.chromium.org/618743003/diff/20001/chrome/test/data/webui/m...
File chrome/test/data/webui/mock_controller.js (right):

https://codereview.chromium.org/618743003/diff/20001/chrome/test/data/webui/m...
chrome/test/data/webui/mock_controller.js:52: * @private
On 2014/09/30 18:12:03, kevers wrote:
> Based on direct access from test case, this is not private.  If the intention
is
> the make it private, then the variable should end in an underscore and be
> modified via a  setter.

Dooh. It should not be private.

[bshe, 2014-09-30 21:59:56]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-09-30 22:01:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/618743003/40001

[commit-bot: I haz the power, 2014-09-30 23:26:38]

Committed patchset #3 (id:40001) as 8f9e81e7c8d53efba7ae2da23a3b7c5ca8b90390

[commit-bot: I haz the power, 2014-09-30 23:27:29]

Patchset 3 (id:??) landed as
https://crrev.com/9c99a1d7cd522e23f1232e53a181c9b21bda2216
Cr-Commit-Position: refs/heads/master@{#297542}

[tapted, 2014-10-01 06:56:41]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/621693002/ by tapted@chromium.org.

The reason for reverting is: WallpaperManagerJsTest.EventPageTest not passing on
Linux ChromiumOS Tests (1)
link:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
errors like

[7412:7412:0930/164710:INFO:CONSOLE(179)] "Failure in test
testSyncOnlineWallpaper
ReferenceError: Constants is not defined", source:  (179)
[7412:7412:0930/164710:INFO:CONSOLE(180)] "ReferenceError: Constants is not
defined
    at testSyncOnlineWallpaper
(file:///tmp/run_tha_teste4P5jV/chrome/test/data/chromeos/wallpaper_manager/unit_tests/event_page_unittest.js:24:11)
    at continueTesting (\u003Canonymous>:177:19)
    at runTests (\u003Canonymous>:153:5)
    at \u003Canonymous>:1:51", source:  (180)
../../chrome/browser/chromeos/extensions/wallpaper_manager_browsertest.cc:89:
Failure
Value of: ExecuteWebUIResourceTest(web_contents, empty_libraries)
  Actual: false
Expected: true
.