Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: sdk/lib/_internal/dartdoc/lib/universe_serializer.dart

Issue 61873007: - Reverting mirror changes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors_impl.dart ('k') | tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/dartdoc/lib/universe_serializer.dart
===================================================================
--- sdk/lib/_internal/dartdoc/lib/universe_serializer.dart (revision 30027)
+++ sdk/lib/_internal/dartdoc/lib/universe_serializer.dart (working copy)
@@ -312,35 +312,23 @@
this.interfaces.add(_optionalReference(interface));
}
- mirror.declarations.values
- .where((d) => d is MethodMirror)
- .forEach((childMirror) {
+ mirror.methods.forEach((childName, childMirror) {
if (!childMirror.isConstructor && !childMirror.isGetter) {
- var childName = childMirror.simpleName;
addChild(new MethodElement(childName, childMirror, lookupMdnComment));
}
});
- mirror.declarations.values
- .where((d) => d is MethodMirror && d.isGetter)
- .forEach((childMirror) {
- var childName = childMirror.simpleName;
+ mirror.getters.forEach((childName, childMirror) {
addChild(new GetterElement(childName, childMirror, lookupMdnComment));
});
- mirror.declarations.values
- .where((d) => d is VariableMirror)
- .forEach((childMirror) {
- var childName = childMirror.simpleName;
- addChild(new VariableElement(childName, childMirror,
- lookupMdnComment));
+ mirror.variables.forEach((childName, childMirror) {
+ addChild(new VariableElement(childName, childMirror,
+ lookupMdnComment));
});
- mirror.declarations.values
- .where((d) => d is MethodMirror && d.isConstructor)
- .forEach((childMirror) {
- var childName = childMirror.simpleName;
- addChild(new MethodElement(childName, methodMirror,
+ mirror.constructors.forEach((constructorName, methodMirror) {
+ addChild(new MethodElement(constructorName, methodMirror,
lookupMdnComment, 'constructor'));
});
« no previous file with comments | « runtime/lib/mirrors_impl.dart ('k') | tests/lib/lib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698