Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: Source/core/frame/PlatformEventController.h

Issue 618673002: Oilpan: reliably track listening PlatformEventControllers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Don't start updating in a stopped context Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/PlatformEventController.h
diff --git a/Source/core/frame/PlatformEventController.h b/Source/core/frame/PlatformEventController.h
index 959a0a2650e9cc9567b9f869b7cf9ecbfd4dbe99..4beec197ed694c590f6be1f13a246559ab8ffa2f 100644
--- a/Source/core/frame/PlatformEventController.h
+++ b/Source/core/frame/PlatformEventController.h
@@ -15,7 +15,7 @@ namespace blink {
// It watches page visibility and calls stopUpdating when page is not visible.
// It provides a didUpdateData() callback method which is called when new data
// it available.
-class PlatformEventController : public PageLifecycleObserver {
+class PlatformEventController : public WillBeGarbageCollectedMixin, public PageLifecycleObserver {
public:
void startUpdating();
void stopUpdating();
@@ -23,6 +23,8 @@ public:
// This is called when new data becomes available.
virtual void didUpdateData() = 0;
+ virtual void trace(Visitor*) { }
+
protected:
explicit PlatformEventController(Page*);
virtual ~PlatformEventController();
« no previous file with comments | « Source/core/frame/DeviceSingleWindowEventController.cpp ('k') | Source/core/frame/PlatformEventDispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698