Source/modules/battery/BatteryManager.cpp - Issue 618673002: Oilpan: reliably track listening PlatformEventControllers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/battery/BatteryManager.cpp

Issue 618673002: Oilpan: reliably track listening PlatformEventControllers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/PlatformEventDispatcher.h ('K') | « Source/core/frame/PlatformEventDispatcher.cpp ('k') | Source/modules/gamepad/NavigatorGamepad.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/battery/BatteryManager.cpp

diff --git a/Source/modules/battery/BatteryManager.cpp b/Source/modules/battery/BatteryManager.cpp

index a100fe59d4725c5a192a58003ca75cce92b25f1a..4fbe7a10e703f5d4617dad1adcddfc6b4ae9b592 100644

--- a/Source/modules/battery/BatteryManager.cpp

+++ b/Source/modules/battery/BatteryManager.cpp

@@ -89,7 +89,7 @@ void BatteryManager::didUpdateData()

}

Document* document = toDocument(executionContext());

- if (document->activeDOMObjectsAreSuspended() || document->activeDOMObjectsAreStopped())

+ if (!document || document->activeDOMObjectsAreSuspended() || document->activeDOMObjectsAreStopped())

mlamouri (slow - plz ping) 2014/09/30 17:08:49 Is there any situation where we expect !document?

return;

ASSERT(oldStatus);

@@ -148,6 +148,7 @@ bool BatteryManager::hasPendingActivity() const

void BatteryManager::trace(Visitor* visitor)

{

visitor->trace(m_batteryStatus);

+ PlatformEventController::trace(visitor);

EventTargetWithInlineData::trace(visitor);

}

« Source/core/frame/PlatformEventDispatcher.h ('K') | « Source/core/frame/PlatformEventDispatcher.cpp ('k') | Source/modules/gamepad/NavigatorGamepad.cpp » ('j') | no next file with comments »