Oilpan: reliably track listening PlatformEventControllers.

Source/core/frame/PlatformEventDispatcher.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PlatformEventDispatcher_h
 #define PlatformEventDispatcher_h
 
+#include "platform/heap/Handle.h"
 #include "wtf/Vector.h"
 
 namespace blink {
 class PlatformEventController;
 
 class PlatformEventDispatcher {
 public:
     void addController(PlatformEventController*);
     void removeController(PlatformEventController*);
 
 protected:
     PlatformEventDispatcher();
     virtual ~PlatformEventDispatcher();
 
     void notifyControllers();
 
     virtual void startListening() = 0;
     virtual void stopListening() = 0;
 
 private:
     void purgeControllers();
 
-    Vector<PlatformEventController*> m_controllers;
+    WillBePersistentHeapVector<RawPtrWillBeMember<PlatformEventController> > m_controllers;

[haraken, 2014/09/30 12:02:14]

Are you sure that this persistent heap vector of members doesn't cause a memory
leak? I'm wondering this since you're changing a raw pointer to a persistent
handle.

(Previously I tried to move PlatformEventDispatcher to the heap at the same time
and make m_controllers a HeapHashMap of weak members, although I didn't complete
the CL at that time :-)

[sof, 2014/09/30 12:12:21]

I haven't done a complete testrun with --enable-leak-detection, but the
module-specific tests that are relevant here don't show up leaks afaict.

That's for leaks on shutdown. If this unnecessarily prolong lifetimes, is a
separate matter. But the onus on unregistering ought to be with the controllers.

     bool m_needsPurge;
     bool m_isDispatching;
 };
 
 } // namespace blink
 
 #endif // PlatformEventDispatcher_h