Fix for keyboard mic: set flag in AudioEntry so that we unregister.

Fix for keyboard mic: set flag in AudioEntry so that we unregister.

We never unregistered an audio stream that were using keyboard mic channel, so we never inactivated the keyboard mic when no more streams were using it. This fixes it.

Fix for CL https://codereview.chromium.org/599443003/

BUG=418993
Committed: https://crrev.com/0bfdfae40975dc873fb67634dec413890002f375
Cr-Commit-Position: refs/heads/master@{#297822}

[Henrik Grunell, 2014-09-30 14:48:18]

grunell@chromium.org changed reviewers:
+ xians@chromium.org

[Henrik Grunell, 2014-10-02 12:20:07]

On 2014/09/30 14:48:28, Henrik Grunell wrote:

Ping. I need to merge this fix. Please review asap.

[no longer working on chromium, 2014-10-02 12:26:43]

https://codereview.chromium.org/618663003/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/media/audio_input_renderer_host.cc (right):

https://codereview.chromium.org/618663003/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/media/audio_input_renderer_host.cc:419:
media::CHANNEL_LAYOUT_STEREO_AND_KEYBOARD_MIC) {
nit, indentation, it should be
if (config.params.channel_layout() ==
        media::CHANNEL_LAYOUT_STEREO_AND_KEYBOARD_MIC)) {

https://codereview.chromium.org/618663003/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/media/audio_input_renderer_host.cc:420:
entry->has_keyboard_mic_ = true;
why don't I see this has_keyboard_mic_ flag in the AudioEntry?

[no longer working on chromium, 2014-10-02 12:28:55]

lgtm if you fix the indentation.

[Henrik Grunell, 2014-10-02 12:44:56]

https://codereview.chromium.org/618663003/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/media/audio_input_renderer_host.cc (right):

https://codereview.chromium.org/618663003/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/media/audio_input_renderer_host.cc:419:
media::CHANNEL_LAYOUT_STEREO_AND_KEYBOARD_MIC) {
On 2014/10/02 12:26:43, xians1 wrote:
> nit, indentation, it should be
> if (config.params.channel_layout() ==
>         media::CHANNEL_LAYOUT_STEREO_AND_KEYBOARD_MIC)) {

Done.

https://codereview.chromium.org/618663003/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/media/audio_input_renderer_host.cc:420:
entry->has_keyboard_mic_ = true;
On 2014/10/02 12:26:43, xians1 wrote:
> why don't I see this has_keyboard_mic_ flag in the AudioEntry?

See line 61.

[Henrik Grunell, 2014-10-02 12:45:20]

The CQ bit was checked by grunell@chromium.org

[commit-bot: I haz the power, 2014-10-02 12:45:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/618663003/20001

[commit-bot: I haz the power, 2014-10-02 13:34:47]

Committed patchset #2 (id:20001) as 9171c472423de0cdf919e0203784ba88e748e044

[commit-bot: I haz the power, 2014-10-02 13:35:30]

Patchset 2 (id:??) landed as
https://crrev.com/0bfdfae40975dc873fb67634dec413890002f375
Cr-Commit-Position: refs/heads/master@{#297822}