Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: src/objects.cc

Issue 618643003: Implement data property creation for assignments to super.x. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/harmony/super.js » ('j') | test/mjsunit/harmony/super.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 875c20e6d61a22139f40e9ab805057cbd029ad79..48c87496a2e620e91b50af834dcd95e54097e763 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -2906,13 +2906,11 @@ MaybeHandle<Object> Object::SetProperty(LookupIterator* it,
}
if (data_store_mode == SUPER_PROPERTY) {
- if (strict_mode == STRICT) {
- Handle<Object> args[1] = {it->name()};
- THROW_NEW_ERROR(it->isolate(),
- NewReferenceError("not_defined", HandleVector(args, 1)),
- Object);
- }
- return value;
+ LookupIterator own_lookup(it->GetReceiver(), it->name(),
+ LookupIterator::OWN);
+
+ return JSObject::SetProperty(&own_lookup, value, strict_mode, store_mode,
Toon Verwaest 2015/02/16 09:33:11 This is not correct as far as I can tell. Your imp
+ NORMAL_PROPERTY);
}
return AddDataProperty(it, value, NONE, strict_mode, store_mode);
« no previous file with comments | « no previous file | test/mjsunit/harmony/super.js » ('j') | test/mjsunit/harmony/super.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698