Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 618583003: [ServiceWorker] Set setSkipServiceWorker flag of the request from NPAPI plugins (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Set setSkipServiceWorker flag of the request from NPAPI plugins We should not support ServiceWorker for NPAPI plugins. It is because ServiceWorker can mislead these plugins and can cause security problems. This CL sets setSkipServiceWorker flag at the constructor of PluginURLFetcher and WebPluginImpl::InitiateHTTPRequest() and WebPluginImpl::RouteToFrame(). BUG=413094 Committed: https://crrev.com/9b4a861e8438048e06bd8d89da8e6ab635553e19 Cr-Commit-Position: refs/heads/master@{#297616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/child/npapi/plugin_url_fetcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
horo
michaeln@ Could you please review this?
6 years, 2 months ago (2014-09-30 05:54:48 UTC) #2
michaeln
lgtm
6 years, 2 months ago (2014-09-30 19:52:43 UTC) #3
horo
jochen@ Could you please review this?
6 years, 2 months ago (2014-10-01 00:18:35 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-01 07:41:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618583003/1
6 years, 2 months ago (2014-10-01 07:50:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as adb02dd4884772db3ca1108343a5cabef6d0ff2f
6 years, 2 months ago (2014-10-01 09:14:44 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 09:15:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b4a861e8438048e06bd8d89da8e6ab635553e19
Cr-Commit-Position: refs/heads/master@{#297616}

Powered by Google App Engine
This is Rietveld 408576698