Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: Source/core/xml/XMLHttpRequest.h

Issue 618583002: Correct data size argument type in resource loading path to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed #4 and removed assert from XMLHttpRequest.cpp Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/xml/XMLHttpRequest.h
diff --git a/Source/core/xml/XMLHttpRequest.h b/Source/core/xml/XMLHttpRequest.h
index 49828f24c0c59d1ded67777b763a370577e5f9fe..ddaecdca0438e101b64e6b77884529abba0c7068 100644
--- a/Source/core/xml/XMLHttpRequest.h
+++ b/Source/core/xml/XMLHttpRequest.h
@@ -160,7 +160,7 @@ private:
virtual void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent) OVERRIDE;
virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse&) OVERRIDE;
- virtual void didReceiveData(const char* data, int dataLength) OVERRIDE;
+ virtual void didReceiveData(const char* data, unsigned dataLength) OVERRIDE;
// When responseType is set to "blob", didDownloadData() is called instead
// of didReceiveData().
virtual void didDownloadData(int dataLength) OVERRIDE;
@@ -191,7 +191,7 @@ private:
PassOwnPtr<TextResourceDecoder> createDecoder() const;
void initResponseDocument();
- void parseDocumentChunk(const char* data, int dataLength);
+ void parseDocumentChunk(const char* data, unsigned dataLength);
bool areMethodAndURLValidForSend();
@@ -201,7 +201,7 @@ private:
const AtomicString& getRequestHeader(const AtomicString& name) const;
void setRequestHeaderInternal(const AtomicString& name, const AtomicString& value);
- void trackProgress(int dataLength);
+ void trackProgress(long long dataLength);
// Changes m_state and dispatches a readyStateChange event if new m_state
// value is different from last one.
void changeState(State newState);

Powered by Google App Engine
This is Rietveld 408576698