Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Unified Diff: Source/core/loader/WorkerLoaderClientBridge.cpp

Issue 618583002: Correct data size argument type in resource loading path to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/WorkerLoaderClientBridge.cpp
diff --git a/Source/core/loader/WorkerLoaderClientBridge.cpp b/Source/core/loader/WorkerLoaderClientBridge.cpp
index 776084af9a3e7cae49c4ed42a16973641ef82773..e092300a09aad3905db0c65235a748c91c7eea00 100644
--- a/Source/core/loader/WorkerLoaderClientBridge.cpp
+++ b/Source/core/loader/WorkerLoaderClientBridge.cpp
@@ -37,6 +37,7 @@
#include "core/workers/WorkerLoaderProxy.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/PassRefPtr.h"
+#include <limits.h>
namespace blink {
@@ -75,10 +76,11 @@ void WorkerLoaderClientBridge::didReceiveResponse(unsigned long identifier, cons
static void workerGlobalScopeDidReceiveData(ExecutionContext* context, PassRefPtr<ThreadableLoaderClientWrapper> workerClientWrapper, PassOwnPtr<Vector<char> > vectorData)
{
ASSERT_UNUSED(context, context->isWorkerGlobalScope());
+ ASSERT(vectorData->size() <= UINT_MAX);
kouhei (in TOK) 2014/09/30 07:23:03 ditto
tyoshino (SeeGerritForStatus) 2014/09/30 08:14:28 Done.
workerClientWrapper->didReceiveData(vectorData->data(), vectorData->size());
}
-void WorkerLoaderClientBridge::didReceiveData(const char* data, int dataLength)
+void WorkerLoaderClientBridge::didReceiveData(const char* data, unsigned dataLength)
{
OwnPtr<Vector<char> > vector = adoptPtr(new Vector<char>(dataLength)); // needs to be an OwnPtr for usage with createCrossThreadTask.
memcpy(vector->data(), data, dataLength);

Powered by Google App Engine
This is Rietveld 408576698