Source/core/page/EventSource.cpp - Issue 618583002: Correct data size argument type in resource loading path to unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventSource.cpp

Issue 618583002: Correct data size argument type in resource loading path to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add static_cast to RELEASE_ASSERT in AssociatedURLLoader::ClientAdapter::didReceiveData Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/EventSource.cpp

diff --git a/Source/core/page/EventSource.cpp b/Source/core/page/EventSource.cpp

index a647178b1efcc0e84a9c2e860a594a131b0e48fc..8f64c5464270ba1b478b66cb631950ebbb229c1f 100644

--- a/Source/core/page/EventSource.cpp

+++ b/Source/core/page/EventSource.cpp

@@ -262,7 +262,7 @@ void EventSource::didReceiveResponse(unsigned long, const ResourceResponse& resp

}

-void EventSource::didReceiveData(const char* data, int length)

+void EventSource::didReceiveData(const char* data, unsigned length)

{

ASSERT(m_state == OPEN);

ASSERT(m_requestInFlight);

« no previous file with comments | « Source/core/page/EventSource.h ('k') | Source/core/workers/WorkerScriptLoader.h » ('j') | no next file with comments »