Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1530)

Unified Diff: Source/core/loader/DocumentThreadableLoader.h

Issue 618583002: Correct data size argument type in resource loading path to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add static_cast to RELEASE_ASSERT in AssociatedURLLoader::ClientAdapter::didReceiveData Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/DocumentLoader.cpp ('k') | Source/core/loader/DocumentThreadableLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/DocumentThreadableLoader.h
diff --git a/Source/core/loader/DocumentThreadableLoader.h b/Source/core/loader/DocumentThreadableLoader.h
index bf8a3caf87031598008dd431e3826d8d3cecfa86..101b280c37f00e46860e2d3b9100c7f982a22167 100644
--- a/Source/core/loader/DocumentThreadableLoader.h
+++ b/Source/core/loader/DocumentThreadableLoader.h
@@ -74,7 +74,7 @@ class DocumentThreadableLoader FINAL : public ThreadableLoader, private Resource
// RawResourceClient implementation
virtual void dataSent(Resource*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) OVERRIDE;
virtual void responseReceived(Resource*, const ResourceResponse&) OVERRIDE;
- virtual void dataReceived(Resource*, const char* data, int dataLength) OVERRIDE;
+ virtual void dataReceived(Resource*, const char* data, unsigned dataLength) OVERRIDE;
virtual void redirectReceived(Resource*, ResourceRequest&, const ResourceResponse&) OVERRIDE;
virtual void notifyFinished(Resource*) OVERRIDE;
virtual void dataDownloaded(Resource*, int) OVERRIDE;
@@ -87,7 +87,7 @@ class DocumentThreadableLoader FINAL : public ThreadableLoader, private Resource
// Methods containing code to handle resource fetch results which is
// common to both sync and async mode.
void handleResponse(unsigned long identifier, const ResourceResponse&);
- void handleReceivedData(const char* data, int dataLength);
+ void handleReceivedData(const char* data, unsigned dataLength);
void handleSuccessfulFinish(unsigned long identifier, double finishTime);
void didTimeout(Timer<DocumentThreadableLoader>*);
« no previous file with comments | « Source/core/loader/DocumentLoader.cpp ('k') | Source/core/loader/DocumentThreadableLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698