Source/core/fetch/ResourceLoader.cpp - Issue 618583002: Correct data size argument type in resource loading path to unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fetch/ResourceLoader.cpp

Issue 618583002: Correct data size argument type in resource loading path to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add static_cast to RELEASE_ASSERT in AssociatedURLLoader::ClientAdapter::didReceiveData Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/fetch/ResourceLoader.cpp

diff --git a/Source/core/fetch/ResourceLoader.cpp b/Source/core/fetch/ResourceLoader.cpp

index 77f3ed9510d702c9153bbce6236ee8fb8f97b138..1aeb73034cb1c3be24e4795f324d6cc83e1d3603 100644

--- a/Source/core/fetch/ResourceLoader.cpp

+++ b/Source/core/fetch/ResourceLoader.cpp

@@ -434,6 +434,7 @@ void ResourceLoader::didReceiveData(blink::WebURLLoader*, const char* data, int

m_host->didReceiveData(m_resource, data, length, encodedDataLength);

if (m_state == Terminated)

return;

+ RELEASE_ASSERT(length >= 0);

m_resource->appendData(data, length);

}

« no previous file with comments | « Source/core/fetch/Resource.cpp ('k') | Source/core/fetch/ScriptResource.h » ('j') | no next file with comments »