Source/core/fetch/RawResource.h - Issue 618583002: Correct data size argument type in resource loading path to unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fetch/RawResource.h

Issue 618583002: Correct data size argument type in resource loading path to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add static_cast to RELEASE_ASSERT in AssociatedURLLoader::ClientAdapter::didReceiveData Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/fetch/RawResource.h

diff --git a/Source/core/fetch/RawResource.h b/Source/core/fetch/RawResource.h

index aac028d95ea1eff6bdf77cbfa16b43704d8c1fac..a21984c153431645cc80716553f15ae57e9bd5a9 100644

--- a/Source/core/fetch/RawResource.h

+++ b/Source/core/fetch/RawResource.h

@@ -44,7 +44,7 @@ public:

private:

virtual void didAddClient(ResourceClient*) OVERRIDE;

- virtual void appendData(const char*, int) OVERRIDE;

+ virtual void appendData(const char*, unsigned) OVERRIDE;

virtual bool shouldIgnoreHTTPStatusCodeErrors() const OVERRIDE { return true; }

@@ -76,7 +76,7 @@ public:

virtual void dataSent(Resource*, unsigned long long /* bytesSent */, unsigned long long /* totalBytesToBeSent */) { }

virtual void responseReceived(Resource*, const ResourceResponse&) { }

- virtual void dataReceived(Resource*, const char* /* data */, int /* length */) { }

+ virtual void dataReceived(Resource*, const char* /* data */, unsigned /* length */) { }

virtual void redirectReceived(Resource*, ResourceRequest&, const ResourceResponse&) { }

virtual void updateRequest(Resource*, const ResourceRequest&) { }

virtual void dataDownloaded(Resource*, int) { }

« no previous file with comments | « Source/core/fetch/MemoryCacheTest.cpp ('k') | Source/core/fetch/RawResource.cpp » ('j') | no next file with comments »