Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: Source/platform/SharedBuffer.h

Issue 618583002: Correct data size argument type in resource loading path to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed #4 and removed assert from XMLHttpRequest.cpp Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.
3 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 3 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 27 matching lines...) Expand all
38 38
39 namespace blink { 39 namespace blink {
40 40
41 class PLATFORM_EXPORT SharedBuffer : public RefCounted<SharedBuffer> { 41 class PLATFORM_EXPORT SharedBuffer : public RefCounted<SharedBuffer> {
42 public: 42 public:
43 static PassRefPtr<SharedBuffer> create() { return adoptRef(new SharedBuffer) ; } 43 static PassRefPtr<SharedBuffer> create() { return adoptRef(new SharedBuffer) ; }
44 static PassRefPtr<SharedBuffer> create(size_t size) { return adoptRef(new Sh aredBuffer(size)); } 44 static PassRefPtr<SharedBuffer> create(size_t size) { return adoptRef(new Sh aredBuffer(size)); }
45 static PassRefPtr<SharedBuffer> create(const char* c, int i) { return adoptR ef(new SharedBuffer(c, i)); } 45 static PassRefPtr<SharedBuffer> create(const char* c, int i) { return adoptR ef(new SharedBuffer(c, i)); }
46 static PassRefPtr<SharedBuffer> create(const unsigned char* c, int i) { retu rn adoptRef(new SharedBuffer(c, i)); } 46 static PassRefPtr<SharedBuffer> create(const unsigned char* c, int i) { retu rn adoptRef(new SharedBuffer(c, i)); }
47 47
48 static PassRefPtr<SharedBuffer> createPurgeable(const char* c, int i) { retu rn adoptRef(new SharedBuffer(c, i, PurgeableVector::Purgeable)); } 48 static PassRefPtr<SharedBuffer> createPurgeable(const char* c, unsigned size ) { return adoptRef(new SharedBuffer(c, size, PurgeableVector::Purgeable)); }
49 49
50 static PassRefPtr<SharedBuffer> adoptVector(Vector<char>&); 50 static PassRefPtr<SharedBuffer> adoptVector(Vector<char>&);
51 51
52 ~SharedBuffer(); 52 ~SharedBuffer();
53 53
54 // Calling this function will force internal segmented buffers to be merged 54 // Calling this function will force internal segmented buffers to be merged
55 // into a flat buffer. Use getSomeData() whenever possible for better 55 // into a flat buffer. Use getSomeData() whenever possible for better
56 // performance. 56 // performance.
57 const char* data() const; 57 const char* data() const;
58 58
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 // purgeability option does an extra memcpy(). Please use 98 // purgeability option does an extra memcpy(). Please use
99 // SharedBuffer::createPurgeable() if you intend to call unlock(). 99 // SharedBuffer::createPurgeable() if you intend to call unlock().
100 void unlock(); 100 void unlock();
101 101
102 bool isLocked() const; 102 bool isLocked() const;
103 103
104 private: 104 private:
105 SharedBuffer(); 105 SharedBuffer();
106 explicit SharedBuffer(size_t); 106 explicit SharedBuffer(size_t);
107 SharedBuffer(const char*, int); 107 SharedBuffer(const char*, int);
108 SharedBuffer(const char*, int, PurgeableVector::PurgeableOption);
109 SharedBuffer(const unsigned char*, int); 108 SharedBuffer(const unsigned char*, int);
109 SharedBuffer(const char*, unsigned, PurgeableVector::PurgeableOption);
110 110
111 // See SharedBuffer::data(). 111 // See SharedBuffer::data().
112 void mergeSegmentsIntoBuffer() const; 112 void mergeSegmentsIntoBuffer() const;
113 113
114 unsigned m_size; 114 unsigned m_size;
115 mutable PurgeableVector m_buffer; 115 mutable PurgeableVector m_buffer;
116 mutable Vector<char*> m_segments; 116 mutable Vector<char*> m_segments;
117 }; 117 };
118 118
119 } // namespace blink 119 } // namespace blink
120 120
121 #endif // SharedBuffer_h 121 #endif // SharedBuffer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698