Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: Source/core/fetch/Resource.cpp

Issue 618583002: Correct data size argument type in resource loading path to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 7
8 This library is free software; you can redistribute it and/or 8 This library is free software; you can redistribute it and/or
9 modify it under the terms of the GNU Library General Public 9 modify it under the terms of the GNU Library General Public
10 License as published by the Free Software Foundation; either 10 License as published by the Free Software Foundation; either
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 void Resource::checkNotify() 206 void Resource::checkNotify()
207 { 207 {
208 if (isLoading()) 208 if (isLoading())
209 return; 209 return;
210 210
211 ResourceClientWalker<ResourceClient> w(m_clients); 211 ResourceClientWalker<ResourceClient> w(m_clients);
212 while (ResourceClient* c = w.next()) 212 while (ResourceClient* c = w.next())
213 c->notifyFinished(this); 213 c->notifyFinished(this);
214 } 214 }
215 215
216 void Resource::appendData(const char* data, int length) 216 void Resource::appendData(const char* data, unsigned length)
217 { 217 {
218 TRACE_EVENT0("blink", "Resource::appendData"); 218 TRACE_EVENT0("blink", "Resource::appendData");
219 ASSERT(!m_resourceToRevalidate); 219 ASSERT(!m_resourceToRevalidate);
220 ASSERT(!errorOccurred()); 220 ASSERT(!errorOccurred());
221 if (m_options.dataBufferingPolicy == DoNotBufferData) 221 if (m_options.dataBufferingPolicy == DoNotBufferData)
222 return; 222 return;
223 if (m_data) 223 if (m_data)
224 m_data->append(data, length); 224 m_data->append(data, length);
225 else 225 else
226 m_data = SharedBuffer::createPurgeable(data, length); 226 m_data = SharedBuffer::createPurgeable(data, length);
(...skipping 790 matching lines...) Expand 10 before | Expand all | Expand 10 after
1017 return "ImportResource"; 1017 return "ImportResource";
1018 case Resource::Media: 1018 case Resource::Media:
1019 return "Media"; 1019 return "Media";
1020 } 1020 }
1021 ASSERT_NOT_REACHED(); 1021 ASSERT_NOT_REACHED();
1022 return "Unknown"; 1022 return "Unknown";
1023 } 1023 }
1024 #endif // !LOG_DISABLED 1024 #endif // !LOG_DISABLED
1025 1025
1026 } 1026 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698