Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Side by Side Diff: Source/core/fetch/RawResource.cpp

Issue 618583002: Correct data size argument type in resource loading path to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add static_cast to RELEASE_ASSERT in AssociatedURLLoader::ClientAdapter::didReceiveData Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/fetch/RawResource.h ('k') | Source/core/fetch/Resource.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All Rights Reserved. 2 * Copyright (C) 2011 Google Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 20 matching lines...) Expand all
31 #include "core/fetch/ResourceLoader.h" 31 #include "core/fetch/ResourceLoader.h"
32 #include "platform/SharedBuffer.h" 32 #include "platform/SharedBuffer.h"
33 33
34 namespace blink { 34 namespace blink {
35 35
36 RawResource::RawResource(const ResourceRequest& resourceRequest, Type type) 36 RawResource::RawResource(const ResourceRequest& resourceRequest, Type type)
37 : Resource(resourceRequest, type) 37 : Resource(resourceRequest, type)
38 { 38 {
39 } 39 }
40 40
41 void RawResource::appendData(const char* data, int length) 41 void RawResource::appendData(const char* data, unsigned length)
42 { 42 {
43 Resource::appendData(data, length); 43 Resource::appendData(data, length);
44 44
45 ResourcePtr<RawResource> protect(this); 45 ResourcePtr<RawResource> protect(this);
46 ResourceClientWalker<RawResourceClient> w(m_clients); 46 ResourceClientWalker<RawResourceClient> w(m_clients);
47 while (RawResourceClient* c = w.next()) 47 while (RawResourceClient* c = w.next())
48 c->dataReceived(this, data, length); 48 c->dataReceived(this, data, length);
49 } 49 }
50 50
51 void RawResource::didAddClient(ResourceClient* c) 51 void RawResource::didAddClient(ResourceClient* c)
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 for (HTTPHeaderMap::const_iterator i = oldHeaders.begin(); i != end; ++i) { 184 for (HTTPHeaderMap::const_iterator i = oldHeaders.begin(); i != end; ++i) {
185 AtomicString headerName = i->key; 185 AtomicString headerName = i->key;
186 if (!shouldIgnoreHeaderForCacheReuse(headerName) && i->value != newHeade rs.get(headerName)) 186 if (!shouldIgnoreHeaderForCacheReuse(headerName) && i->value != newHeade rs.get(headerName))
187 return false; 187 return false;
188 } 188 }
189 189
190 return true; 190 return true;
191 } 191 }
192 192
193 } // namespace blink 193 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/fetch/RawResource.h ('k') | Source/core/fetch/Resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698