Correct data size argument type in resource loading path to unsigned

Source/core/fetch/MemoryCacheTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 33 matching lines @@
 
 class MemoryCacheTest : public ::testing::Test {
 public:
     class FakeDecodedResource : public blink::Resource {
     public:
         FakeDecodedResource(const ResourceRequest& request, Type type)
             : Resource(request, type)
         {
         }
 
-        virtual void appendData(const char* data, int len)
+        virtual void appendData(const char* data, unsigned len)
         {
             Resource::appendData(data, len);
             setDecodedSize(this->size());
         }
 
     protected:
         virtual void destroyDecodedDataIfPossible() OVERRIDE
         {
             setDecodedSize(0);
         }
@@ skipping 78 matching lines @@
     memoryCache()->setDelayBeforeLiveDecodedPrune(0);
     memoryCache()->setMaxPruneDeferralDelay(0);
     const unsigned totalCapacity = 1000000;
     const unsigned minDeadCapacity = 0;
     const unsigned maxDeadCapacity = 0;
     memoryCache()->setCapacities(minDeadCapacity, maxDeadCapacity, totalCapacity);
 
     Resource* cachedResource =
         new Resource(ResourceRequest("http://test/resource"), Resource::Raw);
     const char data[5] = "abcd";
-    cachedResource->appendData(data, 3);
+    cachedResource->appendData(data, 3u);
     // The resource size has to be nonzero for this test to be meaningful, but
     // we do not rely on it having any particular value.
     ASSERT_GT(cachedResource->size(), 0u);
 
     ASSERT_EQ(0u, memoryCache()->deadSize());
     ASSERT_EQ(0u, memoryCache()->liveSize());
 
     memoryCache()->add(cachedResource);
     ASSERT_EQ(cachedResource->size(), memoryCache()->deadSize());
     ASSERT_EQ(0u, memoryCache()->liveSize());
 
     memoryCache()->prune();
     ASSERT_EQ(0u, memoryCache()->deadSize());
     ASSERT_EQ(0u, memoryCache()->liveSize());
 }
 
 // Verified that when ordering a prune in a runLoop task, the prune
 // is deferred to the end of the task.
 TEST_F(MemoryCacheTest, LiveResourceEvictionAtEndOfTask)
 {
     memoryCache()->setDelayBeforeLiveDecodedPrune(0);
     const unsigned totalCapacity = 1;
     const unsigned minDeadCapacity = 0;
     const unsigned maxDeadCapacity = 0;
     memoryCache()->setCapacities(minDeadCapacity, maxDeadCapacity, totalCapacity);
     const char data[6] = "abcde";
     Resource* cachedDeadResource =
         new Resource(ResourceRequest("hhtp://foo"), Resource::Raw);
-    cachedDeadResource->appendData(data, 3);
+    cachedDeadResource->appendData(data, 3u);
     ResourcePtr<Resource> cachedLiveResource =
         new FakeDecodedResource(ResourceRequest("http://test/resource"), Resource::Raw);
     MockImageResourceClient client;
     cachedLiveResource->addClient(&client);
-    cachedLiveResource->appendData(data, 4);
+    cachedLiveResource->appendData(data, 4u);
 
     class Task1 : public blink::WebThread::Task {
     public:
         Task1(const ResourcePtr<Resource>& live, Resource* dead)
             : m_live(live)
             , m_dead(dead)
         { }
 
         virtual void run() OVERRIDE
         {
@@ skipping 49 matching lines @@
 
 // Verifies that cached resources are evicted immediately after release when
 // the total dead resource size is more than double the dead resource capacity.
 TEST_F(MemoryCacheTest, ClientRemoval)
 {
     const char data[6] = "abcde";
     ResourcePtr<Resource> resource1 =
         new FakeDecodedResource(ResourceRequest("http://foo.com"), Resource::Raw);
     MockImageResourceClient client1;
     resource1->addClient(&client1);
-    resource1->appendData(data, 4);
+    resource1->appendData(data, 4u);
     ResourcePtr<Resource> resource2 =
         new FakeDecodedResource(ResourceRequest("http://test/resource"), Resource::Raw);
     MockImageResourceClient client2;
     resource2->addClient(&client2);
-    resource2->appendData(data, 4);
+    resource2->appendData(data, 4u);
 
     const unsigned minDeadCapacity = 0;
     const unsigned maxDeadCapacity = ((resource1->size() + resource2->size()) / 2) - 1;
     const unsigned totalCapacity = maxDeadCapacity;
     memoryCache()->setCapacities(minDeadCapacity, maxDeadCapacity, totalCapacity);
     memoryCache()->add(resource1.get());
     memoryCache()->add(resource2.get());
     // Call prune. There is nothing to prune, but this will initialize
     // the prune timestamp, allowing future prunes to be deferred.
     memoryCache()->prune();
@@ skipping 33 matching lines @@
         new FakeDecodedResource(ResourceRequest("http://foo.com"), Resource::Raw);
     ResourcePtr<FakeDecodedResource> cachedImageHighPriority =
         new FakeDecodedResource(ResourceRequest("http://test/resource"), Resource::Raw);
 
     MockImageResourceClient clientLowPriority;
     MockImageResourceClient clientHighPriority;
     cachedImageLowPriority->addClient(&clientLowPriority);
     cachedImageHighPriority->addClient(&clientHighPriority);
 
     const char data[5] = "abcd";
-    cachedImageLowPriority->appendData(data, 1);
-    cachedImageHighPriority->appendData(data, 4);
+    cachedImageLowPriority->appendData(data, 1u);
+    cachedImageHighPriority->appendData(data, 4u);
     const unsigned lowPrioritySize = cachedImageLowPriority->size();
     const unsigned highPrioritySize = cachedImageHighPriority->size();
     const unsigned lowPriorityMockDecodeSize = cachedImageLowPriority->decodedSize();
     const unsigned highPriorityMockDecodeSize = cachedImageHighPriority->decodedSize();
     const unsigned totalSize = lowPrioritySize + highPrioritySize;
 
     // Verify that the sizes are different to ensure that we can test eviction order.
     ASSERT_GT(lowPrioritySize, 0u);
     ASSERT_NE(lowPrioritySize, highPrioritySize);
     ASSERT_GT(lowPriorityMockDecodeSize, 0u);
@@ skipping 70 matching lines @@
     EXPECT_TRUE(memoryCache()->contains(resource3.get()));
     EXPECT_FALSE(memoryCache()->contains(resource2.get()));
 
     memoryCache()->replace(resource1.get(), resource2.get());
     EXPECT_TRUE(memoryCache()->contains(resource1.get()));
     EXPECT_FALSE(memoryCache()->contains(resource2.get()));
     EXPECT_FALSE(memoryCache()->contains(resource3.get()));
 }
 
 } // namespace