[Base] Use variadic template in callback_list.h (wave 1)

[Base] Use variadic template in callback_list.h

Replace pump.py generated base/callback_list.h with variadic template version.

BUG=None

Committed: https://crrev.com/a28756fae426023c53542f08c1bf80397a28f677
Cr-Commit-Position: refs/heads/master@{#298529}

[tzik, 2014-09-30 16:23:42]

tzik@chromium.org changed reviewers:
+ ajwong@chromium.org

[tzik, 2014-09-30 16:26:38]

PTL.

This piece doesn't need workaround.

[awong, 2014-10-07 18:42:13]

The CQ bit was checked by ajwong@chromium.org

[awong, 2014-10-07 18:42:13]

lgtm

[commit-bot: I haz the power, 2014-10-07 18:43:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/618573002/1

[commit-bot: I haz the power, 2014-10-07 18:48:11]

Committed patchset #1 (id:1) as 5443b890b16fbfeb04cd75f759323ec80e437b38

[commit-bot: I haz the power, 2014-10-07 18:48:55]

Patchset 1 (id:??) landed as
https://crrev.com/a28756fae426023c53542f08c1bf80397a28f677
Cr-Commit-Position: refs/heads/master@{#298529}

[lfg, 2014-10-20 19:00:42]

lfg@chromium.org changed reviewers:
+ lfg@chromium.org

[lfg, 2014-10-20 19:00:43]

This change is breaking compilation on windows using MSVC Express (the compiler
within depot_tools). See
https://code.google.com/p/chromium/issues/detail?id=422794 .

Since right now the benefits from this change are not very relevant, what do you
think about reverting it and waiting until MS compilers have better support for
this feature?

[tzik, 2014-10-21 07:57:22]

On 2014/10/20 19:00:43, lfg wrote:
> This change is breaking compilation on windows using MSVC Express (the
compiler
> within depot_tools). See
> https://code.google.com/p/chromium/issues/detail?id=422794 .
> 
> Since right now the benefits from this change are not very relevant, what do
you
> think about reverting it and waiting until MS compilers have better support
for
> this feature?

Ah... I'm sad to hear that.
OK, please revert it to fix the build. I hope next MSVC works fine.

BTW, I landed another CL that uses Variadic Templates:
https://codereview.chromium.org/615023002/
Didn't it cause a error?

[lfg, 2014-10-21 14:53:50]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/663083005/ by lfg@chromium.org.

The reason for reverting is: Breaking compilation on windows with MSVC Express..

[lfg, 2014-10-21 14:55:12]

On 2014/10/21 07:57:22, tzik wrote:
> On 2014/10/20 19:00:43, lfg wrote:
> > This change is breaking compilation on windows using MSVC Express (the
> compiler
> > within depot_tools). See
> > https://code.google.com/p/chromium/issues/detail?id=422794 .
> > 
> > Since right now the benefits from this change are not very relevant, what do
> you
> > think about reverting it and waiting until MS compilers have better support
> for
> > this feature?
> 
> Ah... I'm sad to hear that.
> OK, please revert it to fix the build. I hope next MSVC works fine.
> 
> BTW, I landed another CL that uses Variadic Templates:
> https://codereview.chromium.org/615023002/
> Didn't it cause a error?

The error we're getting is an internal compiler error, which suggests that the
feature is supported, but there's some bug around its implementation. I'll not
revert the other change for now, let's wait and see if it causes issues down the
road.