Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 61853003: [Ime] Mark android IME tests as flaky (Closed)

Created:
7 years, 1 month ago by Miguel Garcia
Modified:
7 years, 1 month ago
Reviewers:
Peter Beverloo, bulach
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -20 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 11 chunks +62 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
commit-bot: I haz the power
No comments yet.
7 years, 1 month ago (2013-11-06 12:13:18 UTC) #1
Peter Beverloo
lgtm. Please clarify the patch' title to include Android as well. https://codereview.chromium.org/61853003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): ...
7 years, 1 month ago (2013-11-06 12:16:02 UTC) #2
Miguel Garcia
https://codereview.chromium.org/61853003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/61853003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode82 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:82: crbug/315548 On 2013/11/06 12:16:02, Peter Beverloo wrote: > Please ...
7 years, 1 month ago (2013-11-06 12:20:36 UTC) #3
bulach
lgtm (don't forget to update the title as peter suggested)
7 years, 1 month ago (2013-11-06 12:42:01 UTC) #4
Miguel Garcia
On 2013/11/06 12:42:01, bulach wrote: > lgtm (don't forget to update the title as peter ...
7 years, 1 month ago (2013-11-06 12:42:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/61853003/50001
7 years, 1 month ago (2013-11-06 12:56:45 UTC) #6
Peter Beverloo
7 years, 1 month ago (2013-11-06 16:18:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r233278 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698