Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: Source/bindings/scripts/scripts.gni

Issue 618373003: [bindings] partial interfaces should not violate componentization (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed patch conflict Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/interface_dependency_resolver.py ('k') | Source/bindings/scripts/utilities.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/scripts.gni
diff --git a/Source/bindings/scripts/scripts.gni b/Source/bindings/scripts/scripts.gni
index 1058126d4b7420c5a6d20b1a46c9a9f696906ecd..1969ef20ef8bf9f1d40d40fb8dd58fb2702b280a 100644
--- a/Source/bindings/scripts/scripts.gni
+++ b/Source/bindings/scripts/scripts.gni
@@ -108,8 +108,11 @@ template("generate_event_interfaces") {
# Parameters:
# sources = list of IDL files to compile
# output_dir = string containing the directory to put the output files.
+# output_name_suffix = a suffix after the basename of the output file names.
+# target_component = component to generate code for.
template("idl_compiler") {
output_dir = invoker.output_dir
+ output_name_suffix = invoker.output_name_suffix
action_foreach(target_name) {
# TODO(brettw) GYP adds a "-S before the script name to skip "import site" to
@@ -142,8 +145,8 @@ template("idl_compiler") {
sources = invoker.sources
outputs = [
- "$output_dir/V8{{source_name_part}}.cpp",
- "$output_dir/V8{{source_name_part}}.h",
+ "$output_dir/V8{{source_name_part}}${output_name_suffix}.cpp",
+ "$output_dir/V8{{source_name_part}}${output_name_suffix}.h",
]
args = [
@@ -155,6 +158,8 @@ template("idl_compiler") {
rebase_path("$bindings_modules_output_dir/InterfacesInfoModules.pickle",
root_build_dir),
"--write-file-only-if-changed=1", # Always true for Ninja.
+ "--target-component",
+ invoker.target_component,
"{{source}}",
]
« no previous file with comments | « Source/bindings/scripts/interface_dependency_resolver.py ('k') | Source/bindings/scripts/utilities.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698