Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: Source/bindings/modules/v8/BUILD.gn

Issue 618373003: [bindings] partial interfaces should not violate componentization (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed patch conflict Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/modules/generated.gyp ('k') | Source/bindings/modules/v8/ModuleBindingsInitializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/modules/v8/BUILD.gn
diff --git a/Source/bindings/modules/v8/BUILD.gn b/Source/bindings/modules/v8/BUILD.gn
index e877fc8c86856b0c0bb2e0548770f68202132ccb..8db89bc3e03af99210378d32726c95a51e2932c9 100644
--- a/Source/bindings/modules/v8/BUILD.gn
+++ b/Source/bindings/modules/v8/BUILD.gn
@@ -8,28 +8,37 @@ import("//third_party/WebKit/Source/modules/modules.gni")
visibility = [ "//third_party/WebKit/*" ]
+core_idl_with_modules_dependency_files_list = "$target_gen_dir/core_idl_with_modules_dependency_files.tmp"
+write_file(core_idl_with_modules_dependency_files_list,
+ rebase_path(core_idl_with_modules_dependency_files, root_build_dir))
+
# bindings_modules_generated in modules/v8/generated.gyp
group("bindings_modules_generated") {
deps = [
":bindings_modules_dictionary_impl_generated",
- ":bindings_modules_generated_aggregate",
- ":bindings_modules_generated_individual",
+ ":bindings_modules_v8_generated_aggregate",
+ ":bindings_modules_v8_generated_individual",
+ ":bindings_modules_v8_generated_init_partial",
+ ":bindings_modules_v8_generated_partial_aggregate",
+ ":bindings_modules_v8_generated_partial_individual",
]
}
# bindings_modules_generated_aggregate in modules/v8/generated.gyp
-aggregate_generated_bindings("bindings_modules_generated_aggregate") {
+aggregate_generated_bindings("bindings_modules_v8_generated_aggregate") {
sources = modules_definition_idl_files
component_dir = "modules"
outputs = bindings_modules_generated_aggregate_files
}
# bindings_modules_generated_individual in modules/v8/generated.gyp
-idl_compiler("bindings_modules_generated_individual") {
+idl_compiler("bindings_modules_v8_generated_individual") {
# Note in GYP this is modules_interface_idl_files but this variable is just
# defined to modules_definition_idl_files.
sources = modules_definition_idl_files
output_dir = bindings_modules_v8_output_dir
+ output_name_suffix = ""
+ target_component = "modules"
}
# bindings_modules_dictionary_impl_generated in modules/v8/generated.gyp
@@ -37,3 +46,44 @@ idl_dictionary("bindings_modules_dictionary_impl_generated") {
sources = modules_dictionary_idl_files
outputs = generated_modules_dictionary_files
}
+
+# bindings_modules_generated_individual in modules/v8/generated.gyp
+idl_compiler("bindings_modules_v8_generated_partial_individual") {
+ # Note in GYP this is modules_interface_idl_files but this variable is just
+ # defined to modules_definition_idl_files.
+ sources = core_idl_with_modules_dependency_files + webcore_testing_idl_with_modules_dependency_files
+ output_dir = bindings_modules_v8_output_dir
+ output_name_suffix = "Partial"
+ target_component = "modules"
+}
+
+# bindings_modules_generated_aggregate in modules/v8/generated.gyp
+aggregate_generated_bindings("bindings_modules_v8_generated_partial_aggregate") {
+ sources = core_idl_with_modules_dependency_files
+ component_dir = "modules"
+ outputs = bindings_modules_generated_partial_aggregate_files
+}
+
+# GYP version: Source/bindings/modules/v8/generated.gyp:bindings_modules_v8_generated_init_partial
+action("bindings_modules_v8_generated_init_partial") {
+ script = "$bindings_scripts_dir/generate_init_partial_interfaces.py"
+
+ inputs = [
+ core_idl_with_modules_dependency_files_list,
+ "$bindings_modules_output_dir/InterfacesInfoModules.pickle",
+ ]
+ outputs = [ bindings_modules_generated_init_partial_interfaces_file ]
+
+ args = [
+ "--idl-files-list",
+ rebase_path(core_idl_with_modules_dependency_files_list, root_build_dir),
+ "--output",
+ rebase_path(bindings_modules_generated_init_partial_interfaces_file, root_build_dir),
+ "--write-file-only-if-changed=1",
+ ]
+
+ deps = [
+ "//third_party/WebKit/Source/bindings/modules:interfaces_info",
+ ]
+}
+
« no previous file with comments | « Source/bindings/modules/generated.gyp ('k') | Source/bindings/modules/v8/ModuleBindingsInitializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698