Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: Source/bindings/modules/BUILD.gn

Issue 618373003: [bindings] partial interfaces should not violate componentization (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed patch conflict Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/WrapperTypeInfo.h ('k') | Source/bindings/modules/generated.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/modules/BUILD.gn
diff --git a/Source/bindings/modules/BUILD.gn b/Source/bindings/modules/BUILD.gn
index 08e319eede83b0b9a508d9c648f9e74600a1dcae..7dd1592c0a8eaa07d9ab7b6f18bbc943416cb44e 100644
--- a/Source/bindings/modules/BUILD.gn
+++ b/Source/bindings/modules/BUILD.gn
@@ -10,14 +10,6 @@ import("//third_party/WebKit/Source/build/scripts/scripts.gni")
visibility = [ "//third_party/WebKit/*" ]
-core_idl_files_list = "$target_gen_dir/core_idl_files.tmp"
-write_file(core_idl_files_list,
- rebase_path(core_idl_files, root_build_dir))
-
-modules_idl_files_list = "$target_gen_dir/modules_idl_files.tmp"
-write_file(modules_idl_files_list,
- rebase_path(modules_idl_files, root_build_dir))
-
# GYP version: Source/bindings/modules/generated.gyp:bindings_modules_generated
group("bindings_modules_generated") {
deps = [
@@ -73,8 +65,7 @@ make_names("bindings_modules_generated_event_target_modules_names") {
# GYP version: Source/bindings/modules/generated.gyp:interfaces_info_individual_modules
compute_interfaces_info_individual("interfaces_info_individual_modules") {
sources_static = modules_static_idl_files
- # No generated files currently, will add with constructors
- sources_generated = []
+ sources_generated = modules_generated_dependency_idl_files
output_file =
"$bindings_modules_output_dir/InterfacesInfoModulesIndividual.pickle"
deps = [
@@ -125,7 +116,7 @@ compute_global_objects("modules_global_objects") {
# GYP version: Source/bindings/modules/generated.gyp:modules_core_global_constructors_idls
generate_global_constructors("modules_core_global_constructors_idls") {
- sources = core_idl_files
+ sources = core_idl_files + core_idl_with_modules_dependency_files
global_objects_file = "$bindings_modules_output_dir/GlobalObjectsModules.pickle"
interfaces = modules_core_global_constructors_original_interfaces
component = "Core"
« no previous file with comments | « Source/bindings/core/v8/WrapperTypeInfo.h ('k') | Source/bindings/modules/generated.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698