Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: Source/bindings/core/BUILD.gn

Issue 618373003: [bindings] partial interfaces should not violate componentization (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed patch conflict Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/generated.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/BUILD.gn
diff --git a/Source/bindings/core/BUILD.gn b/Source/bindings/core/BUILD.gn
index 8922aa053f59ab18d0b2ef5928b948ffca250654..caaa05023a0febde5285193ffa058c510d645420 100644
--- a/Source/bindings/core/BUILD.gn
+++ b/Source/bindings/core/BUILD.gn
@@ -8,10 +8,6 @@ import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
visibility = [ "//third_party/WebKit/*" ]
-core_idl_files_list = "$target_gen_dir/core_idl_files.tmp"
-write_file(core_idl_files_list,
- rebase_path(core_idl_files, root_build_dir))
-
# GYP version: Source/bindings/core/generated.gyp:interfaces_info_individual_core
compute_interfaces_info_individual("interfaces_info_individual_core") {
sources_static = core_static_idl_files
@@ -25,7 +21,7 @@ compute_interfaces_info_individual("interfaces_info_individual_core") {
# GYP version: Source/bindings/core/generated.gyp:core_global_objects
compute_global_objects("core_global_objects") {
- sources = core_idl_files
+ sources = core_idl_files + core_idl_with_modules_dependency_files
sources_generated = []
output_file = "$bindings_core_output_dir/GlobalObjectsCore.pickle"
deps = []
@@ -33,7 +29,7 @@ compute_global_objects("core_global_objects") {
# GYP version: Source/bindings/core/generated.gyp:core_global_constructors_idls
generate_global_constructors("core_global_constructors_idls") {
- sources = core_idl_files
+ sources = core_idl_files + core_idl_with_modules_dependency_files
global_objects_file = "$bindings_core_output_dir/GlobalObjectsCore.pickle"
interfaces = core_global_constructors_original_interfaces
component = "Core"
« no previous file with comments | « no previous file | Source/bindings/core/generated.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698