Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 618373003: [bindings] partial interfaces should not violate componentization (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_attributes.py
diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py
index 232cd24e0dfb9aeaec9c566364110dc3323100cb..bbdeeb7d61786f3b99dee6b07ad537c730436b23 100644
--- a/Source/bindings/scripts/v8_attributes.py
+++ b/Source/bindings/scripts/v8_attributes.py
@@ -434,14 +434,20 @@ def scoped_content_attribute_name(interface, attribute):
# [Replaceable]
def setter_callback_name(interface, attribute):
cpp_class_name = cpp_name(interface)
+ namespace_name = [cpp_class_name]
+ if interface.original_interface:
+ namespace_name.append('Partial')
+ namespace_name.append('V8Internal')
haraken 2014/10/16 04:24:08 Can we move actual_cpp_class and remove this code?
tasak 2014/10/17 07:38:18 Done. Added cpp_name_or_partial().
+
extended_attributes = attribute.extended_attributes
if (('Replaceable' in extended_attributes and
'PutForwards' not in extended_attributes) or
is_constructor_attribute(attribute)):
- return '{0}V8Internal::{0}ForceSetAttributeOnThisCallback'.format(cpp_class_name)
+ return '%s::%sForceSetAttributeOnThisCallback' % (
+ ''.join(namespace_name), cpp_class_name)
if attribute.is_read_only and 'PutForwards' not in extended_attributes:
return '0'
- return '%sV8Internal::%sAttributeSetterCallback' % (cpp_class_name, attribute.name)
+ return '%s::%sAttributeSetterCallback' % (''.join(namespace_name), attribute.name)
# [DoNotCheckSecurity], [Unforgeable]

Powered by Google App Engine
This is Rietveld 408576698