[bindings] partial interfaces should not violate componentization

Source/bindings/scripts/compute_interfaces_info_overall.py

 #!/usr/bin/python
 #
 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ skipping 48 matching lines @@
     'inherited_extended_attributes': inherited extended attributes
                                      (all controlling memory management)
 
 * public:
     'is_callback_interface': bool, callback interface or not
     'implemented_as': value of [ImplementedAs=...] on interface (C++ class name)
 
 * paths:
     'full_path': path to the IDL file, so can lookup an IDL by interface name
     'include_path': path for use in C++ #include directives
-    'dependencies_full_paths': paths to dependencies (for merging into main)
-    'dependencies_include_paths': paths for use in C++ #include directives
+    'implemented_interfaces_full_paths':

[tasak, 2014/10/17 07:38:17]

Need to fix this comment.

+        paths to dependencies caused by implemented (for merging into main)
+    'implemented_interfaces_include_paths':

[tasak, 2014/10/17 07:38:17]

Ditto.

+        paths for use in C++ #include directives for implemented
+    'partial_interfaces_full_paths':
+        paths to dependencies caused by partial (for merging into main)

[haraken, 2014/10/16 04:24:07]

partial => partial interfaces

[tasak, 2014/10/17 07:38:17]

Done.

+    'partial_interfaces_include_paths':
+        paths for use in C++ #include directives for partial interface

[haraken, 2014/10/16 04:24:07]

partial interface => partial interfaces

[tasak, 2014/10/17 07:38:17]

Done.

 
 Note that all of these are stable information, unlikely to change without
 moving or deleting files (hence requiring a full rebuild anyway) or significant
 code changes (for inherited extended attributes).
 
 Design doc: http://www.chromium.org/developers/design-documents/idl-build
 """
 
 from collections import defaultdict
 import cPickle as pickle
@@ skipping 180 matching lines @@
         # Implemented interfaces don't need includes, as this is handled in
         # the Blink implementation (they are implemented on |impl| itself,
         # hence header is included in implementing class).
         # However, they are needed for legacy implemented interfaces that
         # are being treated as partial interfaces, until we remove these.
         # http://crbug.com/360435
         implemented_interfaces_include_paths = []
         for implemented_interface_info in implemented_interfaces_info:
             if (implemented_interface_info['is_legacy_treat_as_partial_interface'] and
                 implemented_interface_info['include_path']):
-                implemented_interfaces_include_paths.append(implemented_interface_info['include_path'])
+                implemented_interfaces_include_paths.append(
+                    implemented_interface_info['include_path'])
+
+        dependencies_full_paths = implemented_interfaces_full_paths
+        dependencies_include_paths = implemented_interfaces_include_paths
+        partial_interface_dependencies_full_paths = []
+        partial_interface_dependencies_include_paths = []
+
+        component = idl_filename_to_component(interface_info['full_path'])
+        for full_path in partial_interfaces_full_paths:
+            partial_interface_component = idl_filename_to_component(full_path)
+            if component == partial_interface_component:
+                dependencies_full_paths.append(full_path)
+            else:
+                partial_interface_dependencies_full_paths.append(full_path)

[haraken, 2014/10/16 04:24:07]

This naming is a bit confusing because some partial interface dependencies are
stored into dependencies_full_paths.

Shall we rename them to:

- full_paths
- other_component_full_paths

?

[tasak, 2014/10/17 07:38:17]

Done.

+
+        for include_path in partial_interfaces_include_paths:
+            partial_interface_component = idl_filename_to_component(include_path)
+            if component == partial_interface_component:
+                dependencies_include_paths.append(include_path)
+            else:
+                partial_interface_dependencies_include_paths.append(include_path)

[haraken, 2014/10/16 04:24:07]

Ditto.

- include_paths
- other_component_include_paths

?

[tasak, 2014/10/17 07:38:17]

Done.

 
         interface_info.update({
-            'dependencies_full_paths': (partial_interfaces_full_paths +
-                                        implemented_interfaces_full_paths),
-            'dependencies_include_paths': (partial_interfaces_include_paths +
-                                           implemented_interfaces_include_paths),
+            'dependencies_full_paths': dependencies_full_paths,
+            'dependencies_include_paths': dependencies_include_paths,
+            'partial_interface_dependencies_full_paths':
+                partial_interface_dependencies_full_paths,
+            'partial_interface_dependencies_include_paths':
+                partial_interface_dependencies_include_paths,
         })
 
     # Clean up temporary private information
     for interface_info in interfaces_info.itervalues():
         del interface_info['extended_attributes']
         del interface_info['is_legacy_treat_as_partial_interface']
         del interface_info['parent']
 
     # Compute global_type_info to interfaces_info so that idl_compiler does
     # not need to always calculate the info in __init__.
     compute_global_type_info()
 
 
 ################################################################################
 
 def main():
     options, args = parse_options()
     # args = Input1, Input2, ..., Output
     interfaces_info_filename = args.pop()
     info_individuals = read_pickle_files(args)
 
     compute_interfaces_info_overall(info_individuals)
     write_pickle_file(interfaces_info_filename,
                       interfaces_info,
                       options.write_file_only_if_changed)
 
 
 if __name__ == '__main__':
     sys.exit(main())