Issue 618353004: Revert "Oilpan: Replace the positive heap-contains cache with a binary search tree of memory region…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 618353004: Revert "Oilpan: Replace the positive heap-contains cache with a binary search tree of memory region… (Closed)

Created:
6 years, 2 months ago by jsbell

Modified:
6 years, 2 months ago

Reviewers:
haraken, wibling-chromium, zerny-chromium, eustas, Mads Ager (chromium)

CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium), mkwst+moarreviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert "Oilpan: Replace the positive heap-contains cache with a binary search tree of memory regions." This reverts commit 255c321404ce76fd856ee711420a16cdc0a2cfda. Causing browser test crashes and ASAN failures from layout tests. BUG=419760 TBR=eustas@chromium.org,zerny@chromium.org,ager@chromium.org,wibling@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183145

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+213 lines, -278 lines)			Patch
M	Source/platform/heap/Heap.h	View	5 chunks	+86 lines, -48 lines	0 comments	Download
M	Source/platform/heap/Heap.cpp	View	17 chunks	+61 lines, -218 lines	0 comments	Download
M	Source/platform/heap/HeapTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/heap/ThreadState.h	View	8 chunks	+14 lines, -6 lines	0 comments	Download
M	Source/platform/heap/ThreadState.cpp	View	5 chunks	+51 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jsbell

Committed patchset #1 (id:1) manually as 183145 (presubmit successful).

6 years, 2 months ago (2014-10-02 16:32:48 UTC) #1

zerny-chromium

6 years, 2 months ago (2014-10-03 04:14:19 UTC) #3

Message was sent while issue was closed.

lgtm. Thanks for reverting. It appears that a shutdown sequence can happen while
the tree is in an inconsistent state (the tree root is null but a region exists
that should have been in the tree). Investigating further.

Expand Messages | Collapse Messages