Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 61833006: DO NOT LAND - Code for debugging excess style recalcs (Closed)

Created:
7 years, 1 month ago by eseidel
Modified:
6 years, 8 months ago
Reviewers:
nduca, yurys
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, pdr., abarth-chromium, lushnikov, caseq
Visibility:
Public.

Description

DO NOT LAND - Code for debugging excess style recalcs Ideally the inspector could surface something like this. This printf is fantastically useful for understanding where large style invalidations are coming from. Saving it off in a CL for future use. BUG=316388, 325900

Patch Set 1 #

Patch Set 2 : Update to TOT and add printing of element description #

Patch Set 3 : Add JS stack printing and make output nicer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M Source/core/dom/Node.cpp View 1 2 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eseidel
Others may find this useful some day.
7 years, 1 month ago (2013-11-07 00:07:03 UTC) #1
eseidel
I should figure out how to print the current v8 stack and then this might ...
7 years, 1 month ago (2013-11-07 02:50:28 UTC) #2
eseidel
Filed bug 316388 about making a shipable version of this.
7 years, 1 month ago (2013-11-08 10:32:39 UTC) #3
eseidel
Filed issue 325900 about exposing something like this in the inspector.
7 years ago (2013-12-04 21:56:34 UTC) #4
eseidel
This was landed as style.debug in about:tracing.
6 years, 8 months ago (2014-04-21 18:05:34 UTC) #5
pfeldman
On 2014/04/21 18:05:34, eseidel wrote: > This was landed as style.debug in about:tracing. [+yurys] Lets ...
6 years, 8 months ago (2014-04-22 05:55:50 UTC) #6
esprehn
On 2014/04/22 05:55:50, pfeldman wrote: > On 2014/04/21 18:05:34, eseidel wrote: > > This was ...
6 years, 8 months ago (2014-04-22 05:56:33 UTC) #7
eseidel
6 years, 8 months ago (2014-04-22 06:26:53 UTC) #8
Message was sent while issue was closed.
style.debug is super-useful and I hope we'll show that information in the
inspector soon.   As elliot says, it only makes sense in some sort of
"performance audit" mode, but highlighting large style invalidations has been
really helpful for tracking down performance mistakes in google apps.

Powered by Google App Engine
This is Rietveld 408576698